Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add padding support & make it optional #21

Merged
merged 14 commits into from
Oct 28, 2024
Merged

feat!: add padding support & make it optional #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
41481f4
refactor: encoder/decoder into modules
grjte Oct 18, 2024
f5ce881
refactor: fn into struct with encoder/decoder globals
grjte Oct 18, 2024
307811d
feat: add optional padding to encoder
grjte Oct 18, 2024
2fa5bed
test: encoder with pad/no pad
grjte Oct 18, 2024
98198a2
feat: add optional padding to decoder
grjte Oct 18, 2024
d93fb6b
test: decoder with pad/no pad
grjte Oct 18, 2024
10100a1
chore: bump compiler version to 0.36.0 & nargo fmt
grjte Oct 25, 2024
84a31d8
feat: optimize padding
saleel Oct 25, 2024
e572b5a
feat: assert output length
saleel Oct 25, 2024
e8cd187
fix: fix input/ouput length assertion on non pad
saleel Oct 28, 2024
1af23d0
fix: formattin
saleel Oct 28, 2024
1b51198
Merge pull request #2 from saleel/saleel/optimizations
grjte Oct 28, 2024
61f8541
chore: improve encode length calc
saleel Oct 28, 2024
ed82d92
Merge pull request #3 from saleel/saleel/optimizations
grjte Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
toolchain: [nightly, 0.34.0]
toolchain: [nightly, 0.36.0]
steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand All @@ -38,7 +38,7 @@ jobs:
- name: Install Nargo
uses: noir-lang/[email protected]
with:
toolchain: 0.34.0
toolchain: 0.36.0

- name: Run formatter
run: nargo fmt --check
2 changes: 1 addition & 1 deletion Nargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
name = "noir_base64"
type = "lib"
authors = [""]
compiler_version = ">=0.34.0"
compiler_version = ">=0.36.0"

[dependencies]
Loading
Loading