-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(abi)!: add explicit return type field to ABI. #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
abi-return-type
branch
from
February 17, 2023 14:12
943bc7c
to
6ad921f
Compare
TomAFrench
commented
Feb 17, 2023
kevaundray
reviewed
Feb 17, 2023
kevaundray
approved these changes
Feb 17, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #678
Description
Summary of changes
Draft pending proper error types.
The ABI now has separate fields for the type and witness assignments of the return value. As a know on effect, the circuit's return value is now no longer included in the
InputMap
and so is taken as a separate argument toAbi.encode
and returned separately byAbi.decode
.Some care needs to be taken now when checking to see if an ABI contains a public input as this could either be a public param or a return value, whereas previously we could just search
abi.parameters
for a public parameter. I've added a getter to perform this check for us.Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Additional context