Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): updating noirjs tutorial for 1.0.0 #6792

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

signorecello
Copy link
Contributor

@signorecello signorecello commented Dec 12, 2024

closes #6762 by updating the tutorials to match 1.0.0

made the boilerplate significantly smaller, but it would be great if noirc_abi and acvm_js wasms were inlined. I've been talking with @Thunkar and one of us will probably tackle this sometime soon. For now, there's an ugly snippet here that does the job

the full code is in this PR

@signorecello signorecello requested a review from a team December 12, 2024 16:28
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Peak Memory Sample

Program Peak Memory
keccak256 77.76M
workspace 122.04M
regression_4709 273.24M
ram_blowup_regression 1.60G
private-kernel-tail 204.31M
private-kernel-reset 746.63M
private-kernel-inner 310.59M
parity-root 169.56M

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Compilation Sample

Program Compilation Time %
sha256_regression 0m1.402s 2%
regression_4709 0m0.699s 0%
ram_blowup_regression 0m14.907s 1%
rollup-base-public 3m22.907s 0%
rollup-base-private 3m8.621s 2%
private-kernel-tail 0m1.145s -7%
private-kernel-reset 0m9.252s 18%
private-kernel-inner 0m2.609s 0%
parity-root 0m0.960s -15%
noir-contracts 2m38.639s -12%

Copy link
Contributor

github-actions bot commented Dec 12, 2024

docs/docs/tutorials/noirjs_app.md Show resolved Hide resolved
docs/docs/tutorials/noirjs_app.md Show resolved Hide resolved
docs/docs/tutorials/noirjs_app.md Outdated Show resolved Hide resolved
bun.lockb Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Changes to Brillig bytecode sizes

Generated at commit: 11b5a0501d9098300fe1730822ca64357ab56b7b, compared to commit: b3bca76620229e32c531417c6fa92e4a2c044fa0

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
sha256_regression -3 ✅ -0.04%

Full diff report 👇
Program Brillig opcodes (+/-) %
sha256_regression 6,917 (-3) -0.04%

Copy link
Contributor

Changes to number of Brillig opcodes executed

Generated at commit: 11b5a0501d9098300fe1730822ca64357ab56b7b, compared to commit: b3bca76620229e32c531417c6fa92e4a2c044fa0

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
poseidonsponge_x5_254 -3 ✅ -0.00%

Full diff report 👇
Program Brillig opcodes (+/-) %
poseidonsponge_x5_254 183,750 (-3) -0.00%

@signorecello signorecello added this pull request to the merge queue Dec 16, 2024
Copy link
Contributor

FYI @noir-lang/developerrelations on Noir doc changes.

Merged via the queue into master with commit 1b88adc Dec 16, 2024
64 checks passed
@signorecello signorecello deleted the zkpedro/1.0.0_devrel branch December 16, 2024 18:46
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 17, 2024
…eter (noir-lang/noir#6829)

chore: Use Vec for callstacks (noir-lang/noir#6821)
feat: replace `eval_global_as_array_length` with type/interpreter evaluation (noir-lang/noir#6469)
chore: refactor `DataFlowGraph.insert_instruction_and_results` (noir-lang/noir#6823)
chore(docs): updating noirjs tutorial for 1.0.0 (noir-lang/noir#6792)
feat: Sync from aztec-packages (noir-lang/noir#6824)
chore: Have rust-analyzer use the stable toolchain (noir-lang/noir#6825)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 18, 2024
…r#6810)

chore: move constant creation out of loop (noir-lang/noir#6836)
fix: implement `as_field` and `from_field` in the interpreter (noir-lang/noir#6829)
chore: Use Vec for callstacks (noir-lang/noir#6821)
feat: replace `eval_global_as_array_length` with type/interpreter evaluation (noir-lang/noir#6469)
chore: refactor `DataFlowGraph.insert_instruction_and_results` (noir-lang/noir#6823)
chore(docs): updating noirjs tutorial for 1.0.0 (noir-lang/noir#6792)
feat: Sync from aztec-packages (noir-lang/noir#6824)
chore: Have rust-analyzer use the stable toolchain (noir-lang/noir#6825)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 18, 2024
chore: move constant creation out of loop (noir-lang/noir#6836)
fix: implement `as_field` and `from_field` in the interpreter (noir-lang/noir#6829)
chore: Use Vec for callstacks (noir-lang/noir#6821)
feat: replace `eval_global_as_array_length` with type/interpreter evaluation (noir-lang/noir#6469)
chore: refactor `DataFlowGraph.insert_instruction_and_results` (noir-lang/noir#6823)
chore(docs): updating noirjs tutorial for 1.0.0 (noir-lang/noir#6792)
feat: Sync from aztec-packages (noir-lang/noir#6824)
chore: Have rust-analyzer use the stable toolchain (noir-lang/noir#6825)
TomAFrench added a commit that referenced this pull request Dec 18, 2024
* master:
  fix: detect cycles in globals (#6859)
  chore(ci): Execution time report (#6827)
  chore(ci): Add non determinism check and fixes (#6847)
  chore(docs): updating the solidity contract how-to guide (#6804)
  fix: double alias in path (#6855)
  feat: configurable external check failures (#6810)
  chore: move constant creation out of loop (#6836)
  fix: implement `as_field` and `from_field` in the interpreter (#6829)
  chore: Use Vec for callstacks (#6821)
  feat: replace `eval_global_as_array_length` with type/interpreter evaluation (#6469)
  chore: refactor `DataFlowGraph.insert_instruction_and_results` (#6823)
  chore(docs): updating noirjs tutorial for 1.0.0 (#6792)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update NoirJS tutorial docs to 1.0.0-beta.0
2 participants