-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): updating noirjs tutorial for 1.0.0 #6792
Merged
Merged
+163
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Dec 12, 2024
Peak Memory Sample
|
Compilation Sample
|
🚀 Deployed on https://676073e4703a2838e8b25258--noir-docs.netlify.app |
critesjosh
approved these changes
Dec 16, 2024
Co-authored-by: josh crites <[email protected]>
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
FYI @noir-lang/developerrelations on Noir doc changes. |
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 17, 2024
…eter (noir-lang/noir#6829) chore: Use Vec for callstacks (noir-lang/noir#6821) feat: replace `eval_global_as_array_length` with type/interpreter evaluation (noir-lang/noir#6469) chore: refactor `DataFlowGraph.insert_instruction_and_results` (noir-lang/noir#6823) chore(docs): updating noirjs tutorial for 1.0.0 (noir-lang/noir#6792) feat: Sync from aztec-packages (noir-lang/noir#6824) chore: Have rust-analyzer use the stable toolchain (noir-lang/noir#6825)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 18, 2024
…r#6810) chore: move constant creation out of loop (noir-lang/noir#6836) fix: implement `as_field` and `from_field` in the interpreter (noir-lang/noir#6829) chore: Use Vec for callstacks (noir-lang/noir#6821) feat: replace `eval_global_as_array_length` with type/interpreter evaluation (noir-lang/noir#6469) chore: refactor `DataFlowGraph.insert_instruction_and_results` (noir-lang/noir#6823) chore(docs): updating noirjs tutorial for 1.0.0 (noir-lang/noir#6792) feat: Sync from aztec-packages (noir-lang/noir#6824) chore: Have rust-analyzer use the stable toolchain (noir-lang/noir#6825)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 18, 2024
chore: move constant creation out of loop (noir-lang/noir#6836) fix: implement `as_field` and `from_field` in the interpreter (noir-lang/noir#6829) chore: Use Vec for callstacks (noir-lang/noir#6821) feat: replace `eval_global_as_array_length` with type/interpreter evaluation (noir-lang/noir#6469) chore: refactor `DataFlowGraph.insert_instruction_and_results` (noir-lang/noir#6823) chore(docs): updating noirjs tutorial for 1.0.0 (noir-lang/noir#6792) feat: Sync from aztec-packages (noir-lang/noir#6824) chore: Have rust-analyzer use the stable toolchain (noir-lang/noir#6825)
TomAFrench
added a commit
that referenced
this pull request
Dec 18, 2024
* master: fix: detect cycles in globals (#6859) chore(ci): Execution time report (#6827) chore(ci): Add non determinism check and fixes (#6847) chore(docs): updating the solidity contract how-to guide (#6804) fix: double alias in path (#6855) feat: configurable external check failures (#6810) chore: move constant creation out of loop (#6836) fix: implement `as_field` and `from_field` in the interpreter (#6829) chore: Use Vec for callstacks (#6821) feat: replace `eval_global_as_array_length` with type/interpreter evaluation (#6469) chore: refactor `DataFlowGraph.insert_instruction_and_results` (#6823) chore(docs): updating noirjs tutorial for 1.0.0 (#6792)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6762 by updating the tutorials to match 1.0.0
made the boilerplate significantly smaller, but it would be great if
noirc_abi
andacvm_js
wasms were inlined. I've been talking with @Thunkar and one of us will probably tackle this sometime soon. For now, there's an ugly snippet here that does the jobthe full code is in this PR