feat: skip tests having oracle calls #6666
Conversation
github-actions
bot
added
the
documentation
guipublic
changed the title
|
🚀 Deployed on https://67533ee363257629879fd9f8--noir-docs.netlify.app |
Peak Memory Sample
|
guipublic
added
the
run-external-checks
| if name == ForeignCall::CreateMock.name() { | ||
| OracleResult::Mocked |
There was a problem hiding this comment.
Why aren't all the other mock functions considered to be Mocked status?
There was a problem hiding this comment.
I wanted to identify mocked oracles by looking at the create_mock() function, but it is not easy. Instead I used an heuristic that consider that all oracles are mocked if there is one create_mock.
| @@ -49,6 +49,10 @@ pub(crate) struct TestCommand { | |||
| /// JSON RPC url to solve oracle calls | |||
| #[clap(long)] | |||
| oracle_resolver: Option<String>, | |||
|
|
|||
| /// Flag to skip tests using oracles. | |||
There was a problem hiding this comment.
| /// Flag to skip tests using oracles. | |
| /// Flag to skip tests using unhandled oracles without mocks. |
The way it's phrased sounds like any test with an oracle will be skipped.
tooling/nargo/src/ops/test.rs
Outdated
| for brillig_function in &compiled_program.program.unconstrained_functions { | ||
| match brillig_function.get_oracle_status(ForeignCall::check_oracle_status) { | ||
| OracleResult::Mocked => { | ||
| has_oracle = false; |
There was a problem hiding this comment.
| has_oracle = false; | |
| // Assume that mocks will handle any call. | |
| has_oracle = false; |
There was a problem hiding this comment.
This looks good to me, just a couple of suggestions for additional docs/comments. I'll defer to @TomAFrench whether this should be the default on CI or the env var he did that detects a failure after attempting to run the test.
|
FYI @noir-lang/developerrelations on Noir doc changes. |
Description
Problem*
Resolves #6643
Summary*
Add a 'skip-oracle' flag for the nargo test command.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.