feat: Deduplicate to common ancestor #6518
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
This implements the alternate version mentioned in #6517 where we only hoist if there are multiple ValueIds. This means we do not hoist the loop example given there since there is no usage of
x + 1
before the loop.Summary*
Improves the instruction deduplication optimization by moving the instruction to a common ancestor of both blocks if neither dominate the other.
Additional Context
Testing this to see how much of an improvement it gives. The hoisting doesn't occur recursively (so multiple instructions depending on eachother will only have the first hoisted) and relies on another constant folding pass to change the earlier instructions to the hoisted version so performance can still be improved.
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.