Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid duplicate arrays in SSA #6496

Closed
wants to merge 2 commits into from

Conversation

asterite
Copy link
Collaborator

Description

Problem

Resolves #5756

Summary

Though I didn't notice the example program was reduced by a lot (the keccak call did disappear, but a lot of constrains and array_get are still there).

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably conflicting with #6071. I know that PRs been held up for a little while but I'd still like to get it fixed/merged

@asterite
Copy link
Collaborator Author

Oh, I didn't see that other PR. I noticed a test had "pending" on it while working on the SSA parser and realized it wasn't that hard to fix so I went for it. But it makes sense to wait for the other PR first 👍

@TomAFrench
Copy link
Member

If this addresses #6492 then we should merge as a quick fix in the meantime.

@asterite asterite closed this Nov 18, 2024
@asterite asterite deleted the ab/ssa-avoid-duplicate-arrays branch November 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keccakf1600 instructions aren't being deduplicated as expected
3 participants