chore: replace to_radix directive with brillig #6386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we're falling afoul of us needing to know the size of the return type at compile time but we're only passing this in at runtime. |
|
@guipublic I've synced from aztec-packages now. |
|
Looks like this still doesn't work as the linked PR in aztec-packages only handles revert data and not return data. |
guipublic
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 15, 2024
Copies @guipublic's work from noir-lang/noir#6386 into this repository --------- Co-authored-by: guipublic <[email protected]> Co-authored-by: guipublic <[email protected]>
|
Superceded by AztecProtocol/aztec-packages#9970 |
just-mitch
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 16, 2024
Copies @guipublic's work from noir-lang/noir#6386 into this repository --------- Co-authored-by: guipublic <[email protected]> Co-authored-by: guipublic <[email protected]>
AztecBot
pushed a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Nov 16, 2024
Copies @guipublic's work from noir-lang/noir#6386 into this repository --------- Co-authored-by: guipublic <[email protected]> Co-authored-by: guipublic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #6302
Summary*
Replace to_radix directive with brillig opcodes
Additional Context
The directive opcode is not removed. It will be removed from AztecPackages once this PR is merged and synced.
This is a draft PR, until the next sync from Aztec Pacakges because it requires AztecProtocol/aztec-packages#9408.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.