Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore compression of blocks after msg.len in sha256_var #6206

Merged
merged 5 commits into from
Oct 2, 2024
Merged

fix: ignore compression of blocks after msg.len in sha256_var #6206

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
718945f
fix: ignore compression of blocks after msg.len in sha256_var
saleel Oct 2, 2024
8690de8
chore: add tests for sha246_var_padding regression
saleel Oct 2, 2024
214e7bc
chore: add same_msg_len_variable_padding test for sha256
saleel Oct 2, 2024
edf7906
Merge branch 'master' into saleel/fix-sha256
saleel Oct 2, 2024
49f64d8
chore: fix formatting
saleel Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion noir_stdlib/src/hash/sha256.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ pub fn sha256_var<let N: u32>(msg: [u8; N], message_size: u64) -> [u8; 32] {

// If the block is filled, compress it.
// An un-filled block is handled after this loop.
if msg_byte_ptr == BLOCK_SIZE {
if (msg_start < message_size) & (msg_byte_ptr == BLOCK_SIZE) {
h = sha256_compression(msg_u8_to_u32(msg_block), h);
}
}
Expand Down
Loading