Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from aztec-packages #6109

Closed
wants to merge 4 commits into from
Closed

feat: Sync from aztec-packages #6109

wants to merge 4 commits into from

Conversation

AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Sep 20, 2024

Automated pull of Noir development from aztec-packages.
BEGIN_COMMIT_OVERRIDE
feat!: add support for u1 in the avm, ToRadix's radix arg is a memory addr (AztecProtocol/aztec-packages#8570)
feat: Optimize allocating immediate amounts of memory (AztecProtocol/aztec-packages#8579)
END_COMMIT_OVERRIDE

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Changes to Brillig bytecode sizes

Generated at commit: cf7dabb31f04169f483e80e551409dfc0b9e72b2, compared to commit: aea5cc789ccf4a4d16b1d238d99474f37920b37e

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
to_bytes_integration +2 ❌ +4.00%
simple_radix +1 ❌ +2.50%
slice_loop -7 ✅ -2.31%
brillig_hash_to_field -3 ✅ -2.42%
hash_to_field -3 ✅ -2.42%
brillig_calls_conditionals -3 ✅ -2.52%
regression_3607 -1 ✅ -2.56%
references -9 ✅ -3.05%
generics -6 ✅ -3.09%
brillig_loop -2 ✅ -3.17%
reference_only_used_as_alias -9 ✅ -3.61%

Full diff report 👇
Program Brillig opcodes (+/-) %
to_bytes_integration 52 (+2) +4.00%
simple_radix 41 (+1) +2.50%
array_len 63 (+1) +1.61%
to_le_bytes 125 (+1) +0.81%
to_bytes_consistent 145 (+1) +0.69%
regression_4709 133,793 (-1) -0.00%
brillig_cow_regression 1,194 (-2) -0.17%
6_array 403 (-1) -0.25%
strings 1,574 (-4) -0.25%
array_dynamic_nested_blackbox_input 380 (-1) -0.26%
regression_struct_array_conditional 675 (-2) -0.30%
ecdsa_secp256k1 335 (-1) -0.30%
wildcard_type 272 (-1) -0.37%
aes128_encrypt 491 (-2) -0.41%
poseidon_bn254_hash 5,714 (-24) -0.42%
poseidon_bn254_hash_width_3 5,714 (-24) -0.42%
brillig_pedersen 218 (-1) -0.46%
pedersen_check 218 (-1) -0.46%
merkle_insert 802 (-4) -0.50%
bigint 3,923 (-20) -0.51%
regression_capacity_tracker 191 (-1) -0.52%
poseidonsponge_x5_254 4,544 (-24) -0.53%
regression 699 (-4) -0.57%
array_sort 346 (-2) -0.57%
derive 171 (-1) -0.58%
brillig_oracle 339 (-2) -0.59%
regression_5252 5,452 (-33) -0.60%
array_dynamic 304 (-2) -0.65%
eddsa 16,712 (-110) -0.65%
struct_inputs 299 (-2) -0.66%
nested_array_dynamic 2,812 (-19) -0.67%
6 708 (-5) -0.70%
simple_2d_array 135 (-1) -0.74%
7 130 (-1) -0.76%
blake3 130 (-1) -0.76%
brillig_blake3 130 (-1) -0.76%
slice_dynamic_index 2,543 (-20) -0.78%
brillig_blake2s 127 (-1) -0.78%
databus_two_calldata 253 (-2) -0.78%
array_if_cond_simple 121 (-1) -0.82%
brillig_sha256 121 (-1) -0.82%
conditional_regression_661 119 (-1) -0.83%
nested_array_in_slice 1,423 (-12) -0.84%
fold_complex_outputs 796 (-7) -0.87%
sha2_byte 3,633 (-32) -0.87%
uhashmap 25,390 (-228) -0.89%
conditional_regression_short_circuit 207 (-2) -0.96%
fold_call_witness_condition 101 (-1) -0.98%
array_dynamic_blackbox_input 394 (-4) -1.01%
regression_mem_op_predicate 98 (-1) -1.01%
poseidon2 285 (-3) -1.04%
bench_2_to_17 279 (-3) -1.06%
slice_regex 6,089 (-67) -1.09%
tuple_inputs 341 (-4) -1.16%
u128 3,279 (-39) -1.18%
array_neq 84 (-1) -1.18%
array_eq 82 (-1) -1.20%
cast_and_shift_global 164 (-2) -1.20%
conditional_1 649 (-8) -1.22%
hashmap 30,406 (-388) -1.26%
schnorr 938 (-12) -1.26%
no_predicates_numeric_generic_poseidon 698 (-9) -1.27%
fold_numeric_generic_poseidon 698 (-9) -1.27%
binary_operator_overloading 387 (-5) -1.28%
brillig_keccak 2,661 (-35) -1.30%
keccak256 2,661 (-35) -1.30%
slices 2,443 (-33) -1.33%
global_consts 217 (-3) -1.36%
sha256_regression 7,869 (-111) -1.39%
brillig_slices 567 (-8) -1.39%
fold_2_to_17 533 (-8) -1.48%
brillig_cow 398 (-6) -1.49%
7_function 595 (-9) -1.49%
side_effects_constrain_array 132 (-2) -1.49%
array_to_slice 986 (-17) -1.69%
brillig_cow_assign 116 (-2) -1.69%
higher_order_functions 748 (-13) -1.71%
regression_4449 910 (-16) -1.73%
sha256_var_size_regression 2,266 (-40) -1.73%
sha256_var_witness_const_regression 1,526 (-28) -1.80%
sha256 2,289 (-43) -1.84%
conditional_2 103 (-2) -1.90%
regression_4202 102 (-2) -1.92%
break_and_continue 50 (-1) -1.96%
slice_loop 296 (-7) -2.31%
brillig_hash_to_field 121 (-3) -2.42%
hash_to_field 121 (-3) -2.42%
brillig_calls_conditionals 116 (-3) -2.52%
regression_3607 38 (-1) -2.56%
references 286 (-9) -3.05%
generics 188 (-6) -3.09%
brillig_loop 61 (-2) -3.17%
reference_only_used_as_alias 240 (-9) -3.61%

@TomAFrench TomAFrench closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants