Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement to_radix #587

Merged
merged 14 commits into from
Jan 11, 2023
Merged

implement to_radix #587

merged 14 commits into from
Jan 11, 2023

Conversation

guipublic
Copy link
Contributor

Description

Implement to_radix

Remove split and to_bytes directives/opcodes so that we only have one to_radix gate and directive.
I added a to_radix built-in which is used by to_bytes. We still need the to_bits builtin in order to benefit from boolean types.
I also refactored comparisons in acir_gen to use range_constraints.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

crates/noirc_evaluator/src/ssa/acir_gen.rs Outdated Show resolved Hide resolved
crates/noirc_evaluator/src/ssa/acir_gen.rs Outdated Show resolved Hide resolved
crates/noirc_evaluator/src/ssa/acir_gen.rs Show resolved Hide resolved
Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks. I think you also need to merge in master as this branch references a bad version of aztec_backend that was redownloading the CRS on every nargo prove.

crates/noirc_evaluator/src/ssa/acir_gen.rs Outdated Show resolved Hide resolved
crates/noirc_evaluator/src/ssa/acir_gen.rs Outdated Show resolved Hide resolved
crates/noirc_evaluator/src/ssa/acir_gen.rs Outdated Show resolved Hide resolved
@kevaundray kevaundray self-requested a review January 11, 2023 17:14
@kevaundray kevaundray merged commit 67dd7cd into master Jan 11, 2023
@kevaundray kevaundray deleted the gd/to_radix branch January 11, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants