Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce the Visitor pattern #5868

Merged
merged 8 commits into from
Aug 30, 2024
+2,574 −1,976
Merged

chore: introduce the Visitor pattern #5868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0b5abf9
Introduce the Visitor pattern and use it in SignatureHelp
asterite Aug 30, 2024
d450731
Use the visitor pattern for LSP completion
asterite Aug 30, 2024
dac5bf0
Complete all visitor methods
asterite Aug 30, 2024
7e606d0
clippy
asterite Aug 30, 2024
086488b
Avoid visiting uneeded nodes
asterite Aug 30, 2024
62486eb
Use the Visitor pattern in DocumentSymbol
asterite Aug 30, 2024
dc0e2a2
Use the Visitor pattern for inlay hints
asterite Aug 30, 2024
89f56ec
Always have a span when visiting a NoirFunction
asterite Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions compiler/noirc_frontend/src/ast/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
mod structure;
mod traits;
mod type_alias;
mod visitor;

pub use visitor::Visitor;

pub use expression::*;
pub use function::*;
Expand Down Expand Up @@ -485,7 +488,7 @@
Self::Public => write!(f, "pub"),
Self::Private => write!(f, "priv"),
Self::CallData(id) => write!(f, "calldata{id}"),
Self::ReturnData => write!(f, "returndata"),

Check warning on line 491 in compiler/noirc_frontend/src/ast/mod.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (returndata)
}
}
}
Loading
Loading