Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): Update stdlib to use explicit numeric generics #5306

Merged
merged 103 commits into from
Jun 25, 2024
Merged

feat(stdlib): Update stdlib to use explicit numeric generics #5306

merged 103 commits into from
Jun 25, 2024

Commits on May 30, 2024

  1. initial work on explicit numeric generics and initial working tests

    @vezenovm
    vezenovm committed May 30, 2024
    Configuration menu
    Copy the full SHA
    b0a0bc9 View commit details
    Browse the repository at this point in the history

  2. error for bad numeric generic type

    @vezenovm
    vezenovm committed May 30, 2024
    Configuration menu
    Copy the full SHA
    6a6081f View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. merge w/ master and working explicit numeric generics

    @vezenovm
    vezenovm committed May 31, 2024
    Configuration menu
    Copy the full SHA
    49362cf View commit details
    Browse the repository at this point in the history

  2. fmt and clippy

    @vezenovm
    vezenovm committed May 31, 2024
    Configuration menu
    Copy the full SHA
    c9e84e4 View commit details
    Browse the repository at this point in the history

  3. fully working explciit num generics in resolver elaborator still has … 

    …some bugs
    @vezenovm
    vezenovm committed May 31, 2024
    Configuration menu
    Copy the full SHA
    cef55da View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. working numeric_generics test with elaborator

    @vezenovm
    vezenovm committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    84f4b2c View commit details
    Browse the repository at this point in the history

  2. little cleanup

    @vezenovm
    vezenovm committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0e56748 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. error for numeric generic used as type

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    3de41d6 View commit details
    Browse the repository at this point in the history

  2. fmt and clippy

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8c2860a View commit details
    Browse the repository at this point in the history

  3. merge w/ master

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8809853 View commit details
    Browse the repository at this point in the history

  4. add span method ot UnresolvedGeneric

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    11655d5 View commit details
    Browse the repository at this point in the history

  5. remove dbgs

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    2a098bf View commit details
    Browse the repository at this point in the history

  6. accurate checks against numeric generic used as a type

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    883dfa4 View commit details
    Browse the repository at this point in the history

  7. remove bad errros

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    fe28f92 View commit details
    Browse the repository at this point in the history

  8. improve err for numeric generic used in let type annotation

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e7dcd2b View commit details
    Browse the repository at this point in the history

  9. merge master

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    214ed01 View commit details
    Browse the repository at this point in the history

  10. fix frontend/tests

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6fff4c8 View commit details
    Browse the repository at this point in the history

  11. use type::error for bad numeric generic type

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b7feb20 View commit details
    Browse the repository at this point in the history

  12. use numeric generic in for_loop_over_array test

    @vezenovm
    vezenovm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8159a54 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. make separate numeric_generics_explicit test and ignored non elaborat… 

    …or tests
    @vezenovm
    vezenovm committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2154016 View commit details
    Browse the repository at this point in the history

  2. merge conflicts w/ master

    @vezenovm
    vezenovm committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    fe8f2ca View commit details
    Browse the repository at this point in the history

  3. cleanup with no numeric generics in the old resovler

    @vezenovm
    vezenovm committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e5bfaea View commit details
    Browse the repository at this point in the history

  4. cleanup

    @vezenovm
    vezenovm committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e98df52 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. add TypeKind for Numeric generics and also get them working with impl… 

    …icit numeric generics to get the elaborator working with the stdlib
    @vezenovm
    vezenovm committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    6dc164a View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. fixed remaining errors in stdlib with elaborator and got warning for … 

    …implicit generics working in all cases
    @vezenovm
    vezenovm committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    265e385 View commit details
    Browse the repository at this point in the history

  2. merge w/ master

    @vezenovm
    vezenovm committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c22732e View commit details
    Browse the repository at this point in the history

  3. clippy and fmt

    @vezenovm
    vezenovm committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    03d8c4d View commit details
    Browse the repository at this point in the history

  4. cleanup and fix resolver add-generics from merge

    @vezenovm
    vezenovm committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    316cc47 View commit details
    Browse the repository at this point in the history

  5. a little more comments and cleanup

    @vezenovm
    vezenovm committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    45cec2d View commit details
    Browse the repository at this point in the history

  6. use push and pop scope

    @vezenovm
    vezenovm committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    5f9536b View commit details
    Browse the repository at this point in the history

  7. fix panic in numeric_generic_binary_operation_type_mismatch

    @vezenovm
    vezenovm committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6f387cb View commit details
    Browse the repository at this point in the history

  8. use actual typ even if incorrect for accurate type checking when addi… 

    …ng generics
    @vezenovm
    vezenovm committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3165bc7 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Merge branch 'master' into mv/explicit-numeric-generics

    @vezenovm
    vezenovm authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    b6f6813 View commit details
    Browse the repository at this point in the history

  2. merge conflicts w/ master

    @vezenovm
    vezenovm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    cf6e9a8 View commit details
    Browse the repository at this point in the history

  3. update comment

    @vezenovm
    vezenovm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c880850 View commit details
    Browse the repository at this point in the history

  4. additional comment

    @vezenovm
    vezenovm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    89f51f3 View commit details
    Browse the repository at this point in the history

  5. resolved merge conflicts w/ master

    @vezenovm
    vezenovm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    901c970 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. more robust numeric generic parsing

    @vezenovm
    vezenovm committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    fe97064 View commit details
    Browse the repository at this point in the history

  2. update comments with issue referencing elaborator

    @vezenovm
    vezenovm committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    65aae29 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. merge conflicts w/ master

    @vezenovm
    vezenovm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6d328cb View commit details
    Browse the repository at this point in the history

  2. Update compiler/noirc_frontend/src/hir_def/types.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    e5b12d5 View commit details
    Browse the repository at this point in the history

  3. switch TypeKind -> Kind and Kind rather than bool in ResolvedGeneric

    @vezenovm
    vezenovm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7b31c30 View commit details
    Browse the repository at this point in the history

  4. remove resolve_numeric_type as it is unused in favor of passing in th… 

    …e kind manually
    @vezenovm
    vezenovm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    63302d0 View commit details
    Browse the repository at this point in the history

  5. Update compiler/noirc_frontend/src/parser/parser/function.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1554149 View commit details
    Browse the repository at this point in the history

  6. Update tooling/nargo_cli/build.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8c5fd98 View commit details
    Browse the repository at this point in the history

  7. Update tooling/nargo_fmt/tests/input/fn.nr 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    aa53a05 View commit details
    Browse the repository at this point in the history

  8. shorten numeric_generics_explicit test

    @vezenovm
    vezenovm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    09bcfe0 View commit details
    Browse the repository at this point in the history

  9. correctness of nuric generics test

    @vezenovm
    vezenovm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    3db59b8 View commit details
    Browse the repository at this point in the history

  10. remove at_least(1) for generics

    @vezenovm
    vezenovm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6fa665e View commit details
    Browse the repository at this point in the history

  11. Update compiler/noirc_frontend/src/parser/parser/structs.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    759b7ec View commit details
    Browse the repository at this point in the history

  12. remove unnecessary unwrap_or_default

    @vezenovm
    vezenovm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    eff5960 View commit details
    Browse the repository at this point in the history

  13. rename generic_variable -> generic_type in parser

    @vezenovm
    vezenovm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    752e7f0 View commit details
    Browse the repository at this point in the history

  14. still destructure named generic in resolve_type_inner

    @vezenovm
    vezenovm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    c0fb7ef View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Update compiler/noirc_frontend/src/elaborator/mod.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Jun 16, 2024
    Configuration menu
    Copy the full SHA
    123256b View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. ident and into_ident instead of from

    @vezenovm
    vezenovm committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a021370 View commit details
    Browse the repository at this point in the history

  2. break in inner loop for finding implicit num generics in struct

    @vezenovm
    vezenovm committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    1d05612 View commit details
    Browse the repository at this point in the history

  3. remove generic_idents and switch collection of generics into dc_mod i… 

    …nstead of in the elaborator
    @vezenovm
    vezenovm committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    43cb4d0 View commit details
    Browse the repository at this point in the history

  4. merge conflicts w/ master

    @vezenovm
    vezenovm committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    6146793 View commit details
    Browse the repository at this point in the history

  5. clippy

    @vezenovm
    vezenovm committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0879ffa View commit details
    Browse the repository at this point in the history

  6. get definition typ accurate and add a type to the numeric kind

    @vezenovm
    vezenovm committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    57e5bd5 View commit details
    Browse the repository at this point in the history

  7. resolve build.rs

    @vezenovm
    vezenovm committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    f14de96 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. fix up frontend tests

    @vezenovm
    vezenovm committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4a1f899 View commit details
    Browse the repository at this point in the history

  2. merge conflicts w/ master

    @vezenovm
    vezenovm committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    0bec263 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. update fmt to handle more complex generics

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    31e79df View commit details
    Browse the repository at this point in the history

  2. ignore stdlib warnings for now until I update the stdlib

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7ddae3e View commit details
    Browse the repository at this point in the history

  3. merge conflicts w/ master

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    bcaff2b View commit details
    Browse the repository at this point in the history

  4. fix NamedGeneric signature in is_valid_for_unconstrained_boundary

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    c58b7a6 View commit details
    Browse the repository at this point in the history

  5. fixup trailing in fmt item and build for nargo_cli

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4a7a994 View commit details
    Browse the repository at this point in the history

  6. expand comment in numeric_generic_in_trait_impl_with_extra_impl_gener… 

    …ics test
    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    36be839 View commit details
    Browse the repository at this point in the history

  7. use resolve_generics inside of HirContext

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    5a290d9 View commit details
    Browse the repository at this point in the history

  8. fmt fix in resolve_trait-bound

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ebc38cb View commit details
    Browse the repository at this point in the history

  9. mvoe nested slice check

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    3ef133e View commit details
    Browse the repository at this point in the history

  10. remove ResolvedGeneric::dummy

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    818667e View commit details
    Browse the repository at this point in the history

  11. update GenericTypeVars comment

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4001dfd View commit details
    Browse the repository at this point in the history

  12. check generic args for resolve_trait_as_type

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    154782d View commit details
    Browse the repository at this point in the history

  13. last cleanup in frontend tests and setting of implicit numeric struct… 

    … fields
    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e3cf451 View commit details
    Browse the repository at this point in the history

  14. Update compiler/noirc_frontend/src/elaborator/mod.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    5ebd02d View commit details
    Browse the repository at this point in the history

  15. merge w master

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    12d44cd View commit details
    Browse the repository at this point in the history

  16. make resolve_numeric_kind_type inside of UnresolvedGeneric kind()

    @vezenovm
    vezenovm committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    d6ccab1 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. return result on kind() method of UnresolvedGeneric

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    25d640a View commit details
    Browse the repository at this point in the history

  2. don't return generics from add_existing_generics now that they are re… 

    …solved during def collection
    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    c0a375c View commit details
    Browse the repository at this point in the history

  3. missed dbg

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    05befe5 View commit details
    Browse the repository at this point in the history

  4. remove warnings in stdlib for explicit num generics

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    88a0fa0 View commit details
    Browse the repository at this point in the history

  5. nargo fmt on stdlib

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b7b5f9f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into mv/explicit-numeric-generics

    @vezenovm
    vezenovm authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1d8d65f View commit details
    Browse the repository at this point in the history

  7. Update compiler/noirc_frontend/src/hir/def_collector/errors.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    13fad23 View commit details
    Browse the repository at this point in the history

  8. Update compiler/noirc_frontend/src/elaborator/traits.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9da3de6 View commit details
    Browse the repository at this point in the history

  9. remove cmmented out struct generics update

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    98fd197 View commit details
    Browse the repository at this point in the history

  10. add back struct_numeric_generic_in_function test

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a6ec927 View commit details
    Browse the repository at this point in the history

  11. fix bad return type from context.resolve_generics

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    f87bc32 View commit details
    Browse the repository at this point in the history

  12. merge conflicts w/ mv/explicit-numeric-generics

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    edc1502 View commit details
    Browse the repository at this point in the history

  13. return DefCollectorErrorKind directly in resolve_numeric_kind_type

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8ba4cec View commit details
    Browse the repository at this point in the history

  14. cleanup kind method and error for kinds

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    2f7315a View commit details
    Browse the repository at this point in the history

  15. fix resolution of constant in turbofish:

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    5dcd517 View commit details
    Browse the repository at this point in the history

  16. fixup some tests

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d3f36e7 View commit details
    Browse the repository at this point in the history

  17. use explicit num generics in regression_4124

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1e5effa View commit details
    Browse the repository at this point in the history

  18. comment out resolved_type.kind() != kind check

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a46ba67 View commit details
    Browse the repository at this point in the history

  19. clippy

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9bc16a4 View commit details
    Browse the repository at this point in the history

  20. fixup test

    @vezenovm
    vezenovm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    4ee9bc4 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge branch 'mv/explicit-numeric-generics' into mv/stdlib-explicit-n… 

    …um-generics
    @vezenovm
    vezenovm authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    40cf15a View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. merge conflicts w/ master

    @vezenovm
    vezenovm committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    71c6266 View commit details
    Browse the repository at this point in the history

  2. prettier

    @vezenovm
    vezenovm committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2c3c996 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mv/stdlib-explicit-num-generics

    @vezenovm
    vezenovm authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    586ca86 View commit details
    Browse the repository at this point in the history