Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(experimental elaborator): Avoid calling add_generics twice on trait methods #5108

Merged
merged 57 commits into from
May 28, 2024
Merged

fix(experimental elaborator): Avoid calling add_generics twice on trait methods #5108

merged 57 commits into from
May 28, 2024

Commits on May 2, 2024

  1. Add elaborator

    @jfecher
    jfecher committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d0afc12 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Merge branch 'master' into jf/elaborator

    @jfecher
    jfecher committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1c433ec View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. More expressions

    @jfecher
    jfecher committed May 6, 2024
    Configuration menu
    Copy the full SHA
    225303f View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Finish each expression kind

    @jfecher
    jfecher committed May 7, 2024
    Configuration menu
    Copy the full SHA
    29e67a1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into jf/elaborator

    @jfecher
    jfecher committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0177c12 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Add compiler flag

    @jfecher
    jfecher committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6b30028 View commit details
    Browse the repository at this point in the history

  2. Move expressions into their own file

    @jfecher
    jfecher committed May 8, 2024
    Configuration menu
    Copy the full SHA
    7550fb8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'jf/elaborator' into jf/integrate-elaborator

    @jfecher
    jfecher committed May 8, 2024
    Configuration menu
    Copy the full SHA
    39d23dc View commit details
    Browse the repository at this point in the history

  4. Connect elaborator

    @jfecher
    jfecher committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2e77d87 View commit details
    Browse the repository at this point in the history

  5. Code review

    @jfecher
    jfecher committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e542d32 View commit details
    Browse the repository at this point in the history

  6. Finish removing Scope

    @jfecher
    jfecher committed May 8, 2024
    Configuration menu
    Copy the full SHA
    fd287df View commit details
    Browse the repository at this point in the history

  7. Merge branch 'jf/elaborator' into jf/integrate-elaborator

    @jfecher
    jfecher committed May 8, 2024
    Configuration menu
    Copy the full SHA
    73dc473 View commit details
    Browse the repository at this point in the history

  8. Finish functions

    @jfecher
    jfecher committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9614b87 View commit details
    Browse the repository at this point in the history

  9. Add should_panic

    @jfecher
    jfecher committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b44c98a View commit details
    Browse the repository at this point in the history

  10. clippy

    @jfecher
    jfecher committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9579646 View commit details
    Browse the repository at this point in the history

  11. Fix test

    @jfecher
    jfecher committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e4d5f61 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Fix test

    @jfecher
    jfecher committed May 9, 2024
    Configuration menu
    Copy the full SHA
    556e6ef View commit details
    Browse the repository at this point in the history

  2. Elaborate impls

    @jfecher
    jfecher committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7487b03 View commit details
    Browse the repository at this point in the history

  3. Fix yet another missed line

    @jfecher
    jfecher committed May 9, 2024
    Configuration menu
    Copy the full SHA
    82d5871 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'jf/integrate-elaborator' into jf/elaborator-impls

    @jfecher
    jfecher committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a3872e0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into jf/integrate-elaborator

    @jfecher
    jfecher committed May 9, 2024
    Configuration menu
    Copy the full SHA
    3fb05dc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'jf/integrate-elaborator' into jf/elaborator-impls

    @jfecher
    jfecher committed May 9, 2024
    Configuration menu
    Copy the full SHA
    4fa4677 View commit details
    Browse the repository at this point in the history

  7. Resolve weird git merge

    @jfecher
    jfecher committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e9e69f4 View commit details
    Browse the repository at this point in the history

  8. Wrong arg order

    @jfecher
    jfecher committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d7d91ae View commit details
    Browse the repository at this point in the history

  9. Merge branch 'jf/integrate-elaborator' into jf/elaborator-impls

    @jfecher
    jfecher committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e9afa1a View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into jf/elaborator-impls

    @jfecher
    jfecher committed May 9, 2024
    Configuration menu
    Copy the full SHA
    13564f8 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Code review

    @jfecher
    jfecher committed May 10, 2024
    Configuration menu
    Copy the full SHA
    75c6451 View commit details
    Browse the repository at this point in the history

  2. Start work on traits + types (+ globals)?

    @jfecher
    jfecher committed May 10, 2024
    Configuration menu
    Copy the full SHA
    bbecf41 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Merge branch 'master' into jf/elaborator-types

    @jfecher
    jfecher committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0029558 View commit details
    Browse the repository at this point in the history

  2. Add globals

    @jfecher
    jfecher committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7a37bf3 View commit details
    Browse the repository at this point in the history

  3. Format

    @jfecher
    jfecher committed May 21, 2024
    Configuration menu
    Copy the full SHA
    464d58c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'jf/elaborator-types' into jf/elaborator-globals

    @jfecher
    jfecher committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ba893ae View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Copy over comments from dc_crate

    @jfecher
    jfecher committed May 22, 2024
    Configuration menu
    Copy the full SHA
    397fe78 View commit details
    Browse the repository at this point in the history

  2. Remove unneeded comment

    @jfecher
    jfecher committed May 22, 2024
    Configuration menu
    Copy the full SHA
    afcf26e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into jf/elaborator-globals

    @jfecher
    jfecher committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1f3e79b View commit details
    Browse the repository at this point in the history

  4. Re-add accidentally removed collect_traits call

    @jfecher
    jfecher committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8522936 View commit details
    Browse the repository at this point in the history

  5. Fix panic in the elaborator

    @jfecher
    jfecher committed May 22, 2024
    Configuration menu
    Copy the full SHA
    bbb7228 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into jf/elaborator-fixes

    @jfecher
    jfecher committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1f9b6d0 View commit details
    Browse the repository at this point in the history

  7. Undo unnecessary change

    @jfecher
    jfecher committed May 22, 2024
    Configuration menu
    Copy the full SHA
    78e6a27 View commit details
    Browse the repository at this point in the history

  8. Remove more unnecessary code

    @jfecher
    jfecher committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3b59749 View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary import

    @jfecher
    jfecher committed May 22, 2024
    Configuration menu
    Copy the full SHA
    bf999d9 View commit details
    Browse the repository at this point in the history

  10. Remove outdated assert

    @jfecher
    jfecher committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7be1561 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into jf/elaborator-fixes

    @jfecher
    jfecher committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f48280d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Fix issue with function generics

    @jfecher
    jfecher committed May 23, 2024
    Configuration menu
    Copy the full SHA
    fadc085 View commit details
    Browse the repository at this point in the history

  2. Clippy

    @jfecher
    jfecher committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f0d249a View commit details
    Browse the repository at this point in the history

  3. Add missed field in test

    @jfecher
    jfecher committed May 23, 2024
    Configuration menu
    Copy the full SHA
    68ccf9c View commit details
    Browse the repository at this point in the history

  4. Fix structs not recovering generics length

    @jfecher
    jfecher committed May 23, 2024
    Configuration menu
    Copy the full SHA
    aa6d581 View commit details
    Browse the repository at this point in the history

  5. Don't check return type for trait methods

    @jfecher
    jfecher committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f519ced View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Fix more errors

    @jfecher
    jfecher committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4e6490c View commit details
    Browse the repository at this point in the history

  2. Clippy

    @jfecher
    jfecher committed May 24, 2024
    Configuration menu
    Copy the full SHA
    38f20e9 View commit details
    Browse the repository at this point in the history

  3. Avoid defining globals twice

    @jfecher
    jfecher committed May 24, 2024
    Configuration menu
    Copy the full SHA
    79aaeb7 View commit details
    Browse the repository at this point in the history

  4. Move code to declare trait impls earlier

    @jfecher
    jfecher committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2303635 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into jf/elaborator-fixes6

    @jfecher
    jfecher committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1451341 View commit details
    Browse the repository at this point in the history

  6. Don't add_generics on trait methods twice

    @jfecher
    jfecher committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e35d9a5 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Merge branch 'master' into jf/elaborator-fixes7

    @jfecher
    jfecher committed May 28, 2024
    Configuration menu
    Copy the full SHA
    25ee0d7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into jf/elaborator-fixes7

    @jfecher
    jfecher committed May 28, 2024
    Configuration menu
    Copy the full SHA
    67add01 View commit details
    Browse the repository at this point in the history

  3. fix(experimental elaborator): Fix panic during monomorphization (#5126) 

    # Description

## Problem\*

Resolves a panic in the elaborator during monomorphization related to
parameters being resolved twice and having a different DefinitionId the
second time.

## Summary\*

I've stored the original ids from the first resolution and switched to
using only those.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
    @jfecher
    jfecher authored May 28, 2024
    Configuration menu
    Copy the full SHA
    13173e8 View commit details
    Browse the repository at this point in the history