Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle ACIR calls in the debugger #5051

Merged
merged 37 commits into from
Jul 12, 2024
Merged

feat: Handle ACIR calls in the debugger #5051

merged 37 commits into from
Jul 12, 2024

Commits on Apr 26, 2024

  1. For disassembly view in DAP mode, return integer addresses 

    Returning serialized opcode locations is invalid according to the DAP
specification and confuses VS.Code.
    @ggiraldez
    ggiraldez committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    14518f8 View commit details
    Browse the repository at this point in the history

  2. Fix unit tests

    @ggiraldez
    ggiraldez committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c0b713d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Update breakpoint set commands to handle new opcode addressing scheme

    @ggiraldez
    ggiraldez committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8e1427c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge remote-tracking branch 'upstream/master' into fix/4904-dap-disa… 

    …ssembly-view
    @ggiraldez
    ggiraldez committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7f36701 View commit details
    Browse the repository at this point in the history

  2. feat: Always output Brillig functions if forcing the runtime

    @ggiraldez
    ggiraldez committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a03f83e View commit details
    Browse the repository at this point in the history

  3. chore: Re-enable debugger tests that should now pass

    @ggiraldez
    ggiraldez committed May 16, 2024
    Configuration menu
    Copy the full SHA
    ca767cf View commit details
    Browse the repository at this point in the history

  4. chore: Pass the whole CompiledProgram into the REPL debugger 

    Make the code consistent with the DAP and enables to start implementing
debugging for multiple circuits.
    @ggiraldez
    ggiraldez committed May 16, 2024
    Configuration menu
    Copy the full SHA
    86afc2c View commit details
    Browse the repository at this point in the history

  5. feat: Return a WitnessStack from the debugger

    @ggiraldez
    ggiraldez committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d39c4fc View commit details
    Browse the repository at this point in the history

  6. feat: The DebugContext now accepts a slice of circuits

    @ggiraldez
    ggiraldez committed May 16, 2024
    Configuration menu
    Copy the full SHA
    582dd6b View commit details
    Browse the repository at this point in the history

  7. feat: Support ACIR calls in the debugger

    @ggiraldez
    ggiraldez committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f3f3b2b View commit details
    Browse the repository at this point in the history

  8. feat: Introduce DebugLocation to consider circuit reference 

    in addition to ACIR and Brillig indices.
    @ggiraldez
    ggiraldez committed May 16, 2024
    Configuration menu
    Copy the full SHA
    79ed5ac View commit details
    Browse the repository at this point in the history

  9. feat: Use DebugLocation and keep circuit ID on each exec frame

    @ggiraldez
    ggiraldez committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2e4abb0 View commit details
    Browse the repository at this point in the history

  10. fix: Address mapping of opcodes now works for all circuits

    @ggiraldez
    ggiraldez committed May 16, 2024
    Configuration menu
    Copy the full SHA
    551827d View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. fix: Consider circuit when computing the source locations

    @ggiraldez
    ggiraldez committed May 17, 2024
    Configuration menu
    Copy the full SHA
    d29e329 View commit details
    Browse the repository at this point in the history

  2. feat: In the REPL, display opcodes for all circuits

    @ggiraldez
    ggiraldez committed May 17, 2024
    Configuration menu
    Copy the full SHA
    4848fc8 View commit details
    Browse the repository at this point in the history

  3. fix: Properly map address to debug location

    @ggiraldez
    ggiraldez committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f407a59 View commit details
    Browse the repository at this point in the history

  4. chore: Test address mapping with multiple circuits

    @ggiraldez
    ggiraldez committed May 17, 2024
    Configuration menu
    Copy the full SHA
    57f4970 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge remote-tracking branch 'upstream/master' into feat/4824-multipl… 

    …e-acir-calls
    @ggiraldez
    ggiraldez committed May 22, 2024
    Configuration menu
    Copy the full SHA
    19b1f89 View commit details
    Browse the repository at this point in the history

  2. fix: Compilation errors

    @ggiraldez
    ggiraldez committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4d12d15 View commit details
    Browse the repository at this point in the history

  3. chore: cargo fmt

    @ggiraldez
    ggiraldez committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b28b07e View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Fix merge conflicts from master

    @mverzilli
    mverzilli committed May 29, 2024
    Configuration menu
    Copy the full SHA
    4bbf039 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge branch 'master' into feat/4824-multiple-acir-calls

    @mverzilli
    mverzilli authored May 30, 2024
    Configuration menu
    Copy the full SHA
    aa37413 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Merge branch 'master' into feat/4824-multiple-acir-calls

    @mverzilli
    mverzilli committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    79b7b91 View commit details
    Browse the repository at this point in the history

  2. Re-enable some debugger integration tests

    @mverzilli
    mverzilli committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    bf9461f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Merge branch 'noir-lang:master' into feat/4824-multiple-acir-calls

    @ggiraldez
    ggiraldez authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    4db5c9e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Update tooling/debugger/src/repl.rs 

    Co-authored-by: Maxim Vezenov <[email protected]>
    @mverzilli @vezenovm
    mverzilli and vezenovm authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c46f253 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Merge branch 'master' into feat/4824-multiple-acir-calls

    @mverzilli
    mverzilli committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    8779bfe View commit details
    Browse the repository at this point in the history

  2. Fix compilation errors introduced in merge from master

    @mverzilli
    mverzilli committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    8e99c6b View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Merge branch 'master' into feat/4824-multiple-acir-calls

    @anaPerezGhiglia
    anaPerezGhiglia committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    94b9d93 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge branch 'master' into feat/4824-multiple-acir-calls

    @anaPerezGhiglia
    anaPerezGhiglia committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    daacdac View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge branch 'master' into feat/4824-multiple-acir-calls

    @anaPerezGhiglia
    anaPerezGhiglia committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e0e529b View commit details
    Browse the repository at this point in the history

  2. fix: PR comments (#3) 

    * clean up DebugLocation::from_str

* Create new AddressMap struct for abstracting acir_opcode_addresses type

---------

Co-authored-by: ggiraldez <[email protected]>
    @anaPerezGhiglia @ggiraldez
    anaPerezGhiglia and ggiraldez authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7e882df View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Merge branch 'master' into feat/4824-multiple-acir-calls

    @anaPerezGhiglia
    anaPerezGhiglia committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d45f8e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/4824-multiple-acir-calls

    @anaPerezGhiglia
    anaPerezGhiglia authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d47f33c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Recover lost change after merge

    @anaPerezGhiglia
    anaPerezGhiglia committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d1ea77c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/4824-multiple-acir-calls

    @anaPerezGhiglia
    anaPerezGhiglia committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d373ba8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat/4824-multiple-acir-calls

    @anaPerezGhiglia
    anaPerezGhiglia committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    17eea72 View commit details
    Browse the repository at this point in the history