Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sync from aztec-packages #4811

Closed
wants to merge 9 commits into from
Closed

feat: Sync from aztec-packages #4811

wants to merge 9 commits into from

Commits on Apr 16, 2024

  1. feat(acir)!: BrilligCall opcode (AztecProtocol/aztec-packages#5709) 

    This starts work towards #3907
but is only the breaking serialization change.

Codegen and evaluation will come in a follow-up. This PR is purely
additive and does not remove the current way we do Brillig gen during
ACIR gen. Codegen for normal Brillig functions is working in my
follow-up, however, removing the existing Brillig opcode will most
likely have to come once we settle on how to [handle the brillig std
lib](noir-lang/acvm#471) as we are currently
generating code such as calculating a quotient during ACIR gen.

---------

Co-authored-by: Tom French <[email protected]>
    @AztecBot @TomAFrench
    AztecBot and TomAFrench committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    8222fc8 View commit details
    Browse the repository at this point in the history

  2. feat: impl of missing functionality in new key store (AztecProtocol/a… 

    …ztec-packages#5750)
    @AztecBot
    AztecBot committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9b3b450 View commit details
    Browse the repository at this point in the history

  3. feat: impl of missing functionality in new key store (AztecProtocol/a… 

    …ztec-packages#5750)
    @AztecBot
    AztecBot committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ffdc1b4 View commit details
    Browse the repository at this point in the history

  4. feat!: trap with revert data (AztecProtocol/aztec-packages#5732) 

    This PR adds revert data for user-defined messages in the TRAP opcode.
Not all messages are returned as revert data, since compiler intrinsic
messages are spammed all over SSA and codegening revert data for all
those makes brillig function size blow up and impacts performance in a
hard way due to deserializing load.
This is currently only for static assert messages, since dynamic ones
are implemented as an oracle and probably need a rework to be able to
return them as revert data.

---------

Co-authored-by: Maxim Vezenov <[email protected]>
    @AztecBot @vezenovm
    AztecBot and vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4553d76 View commit details
    Browse the repository at this point in the history

  5. feat!: trap with revert data (AztecProtocol/aztec-packages#5732) 

    This PR adds revert data for user-defined messages in the TRAP opcode.
Not all messages are returned as revert data, since compiler intrinsic
messages are spammed all over SSA and codegening revert data for all
those makes brillig function size blow up and impacts performance in a
hard way due to deserializing load.
This is currently only for static assert messages, since dynamic ones
are implemented as an oracle and probably need a rework to be able to
return them as revert data.

---------

Co-authored-by: Maxim Vezenov <[email protected]>
    @AztecBot @vezenovm
    AztecBot and vezenovm committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    2994743 View commit details
    Browse the repository at this point in the history

  6. feat!: Use fixed size arrays in black box functions where sizes are k… 

    …nown (AztecProtocol/aztec-packages#5620)

This PR enforces the sizes of inputs/outputs of blackbox functions to
remove some runtime checks and allocations.

---------

Co-authored-by: guipublic <[email protected]>
Co-authored-by: vezenovm <[email protected]>
    @AztecBot @guipublic @vezenovm
    3 people committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1c8d1bf View commit details
    Browse the repository at this point in the history

  7. feat!: Use fixed size arrays in black box functions where sizes are k… 

    …nown (AztecProtocol/aztec-packages#5620)

This PR enforces the sizes of inputs/outputs of blackbox functions to
remove some runtime checks and allocations.

---------

Co-authored-by: guipublic <[email protected]>
Co-authored-by: vezenovm <[email protected]>
    @AztecBot @guipublic @vezenovm
    3 people committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0b34821 View commit details
    Browse the repository at this point in the history

  8. feat!: change backend width to 4 (AztecProtocol/aztec-packages#5374) 

    This is a breaking change because it will change the acir opcode
compiled by Noir. If they are not updated, proving and verification will
fail.

---------

Co-authored-by: Tom French <[email protected]>
    @AztecBot @TomAFrench
    AztecBot and TomAFrench committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    8165f0a View commit details
    Browse the repository at this point in the history

  9. feat!: change backend width to 4 (AztecProtocol/aztec-packages#5374) 

    This is a breaking change because it will change the acir opcode
compiled by Noir. If they are not updated, proving and verification will
fail.

---------

Co-authored-by: Tom French <[email protected]>
    @AztecBot @TomAFrench
    AztecBot and TomAFrench committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    2dda011 View commit details
    Browse the repository at this point in the history