Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optimize merging numeric values #4728

Closed
wants to merge 1 commit into from
Closed

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Apr 5, 2024

Description

Problem*

Resolves

Summary*

Found while working on #4716

This reduces the size of the circuit in #4688 to just 19725 constraints (2314 acir opcodes). Forgot my local version of the test program was modified.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested a review from vezenovm April 5, 2024 16:36
Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfecher
Copy link
Contributor Author

jfecher commented Apr 5, 2024

The difference I was seeing in constraint count was because I forgot I had locally changed the test file.
The CI of this PR indicates it also has no optimization changes elsewhere so I'm closing it.

@jfecher jfecher closed this Apr 5, 2024
@TomAFrench TomAFrench deleted the jf/value-merge-opt branch November 20, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants