Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from aztec-packages #4581

Merged
merged 31 commits into from
Mar 21, 2024
Merged

feat: Sync from aztec-packages #4581

merged 31 commits into from
Mar 21, 2024

Commits on Mar 19, 2024

  1. feat!: automatic NoteInterface and NoteGetterOptions auto select (Azt…

    …ecProtocol/aztec-packages#4508)
    
    Partially addresses:
    AztecProtocol/aztec-packages#4519 (moved
    autogeneration to the macro, even if not incremental)
    Closes: AztecProtocol/aztec-packages#3011
    
    Added the `#[aztec(note)]` attribute, which automatically implements
    most of the `NoteInterface` trait in a struct marked as such, plus
    several utilities. Even if this adds a fair share of "magic" to the note
    implementation logic, it is structured in a way that it's hopefully easy
    to follow, including meaningful errors attached to the correct span
    during the process.
    
    ![Screenshot 2024-03-14 at 14 59
    07](https://github.com/AztecProtocol/aztec-packages/assets/5404052/84a3d6e4-e346-4cfe-93eb-ec317632f344)
    
    Hey you! Implement the trait!
    
    ![Screenshot 2024-03-14 at 14 46
    39](https://github.com/AztecProtocol/aztec-packages/assets/5404052/bebfb3dd-c178-44d0-b9bc-005b5c9f0f38)
    But only the meat and potatoes though.
    
    As long as the user doesn't want to do any custom stuff, `get_header`,
    `set_header`, `compute_note_content_hash`, `get_note_type_id`,
    `serialize_content` and `deserialize_content` get automatically
    implemented. Any combination of them can be overridden by the developer
    though.
    
    A metadata struct is also added, which takes the following form:
    
    ```rust
    struct CardNote {
        points: FieldSelector,
        randomness: FieldSelector,
        owner: FieldSelector,
    }
    ```
    
    This is used to implement a `properties()` function, which in turn can
    be used in conjunction with the `NoteGetterOptions.select` and `.sort`
    
    <img width="697" alt="Screenshot 2024-03-18 at 15 27 27"
    src="https://github.com/AztecProtocol/aztec-packages/assets/5404052/5da531b3-0b7f-4cf9-9908-300ff8d98c6d">
    AztecBot committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    6b4175e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0986c09 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9bb168a View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Configuration menu
    Copy the full SHA
    7d94107 View commit details
    Browse the repository at this point in the history
  2. nargo fmt

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1615085 View commit details
    Browse the repository at this point in the history
  3. update bb.js dep

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c9a637a View commit details
    Browse the repository at this point in the history
  4. lint fix

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    06b10d2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    45e0613 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ec976b3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7ddfd89 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    74ba792 View commit details
    Browse the repository at this point in the history
  9. fix TypeCheckError

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9c7a236 View commit details
    Browse the repository at this point in the history
  10. switch to 0.30.0

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    79323ad View commit details
    Browse the repository at this point in the history
  11. bb native version

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    01f65ed View commit details
    Browse the repository at this point in the history
  12. cover missing err

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c9b7116 View commit details
    Browse the repository at this point in the history
  13. use WitnessStack

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ff36f9f View commit details
    Browse the repository at this point in the history
  14. eslint fix'

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    f2711d8 View commit details
    Browse the repository at this point in the history
  15. uncomment hash check in acvm

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    22fe49c View commit details
    Browse the repository at this point in the history
  16. resolve 0.30.1

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2a883c8 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    c3cae5d View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    c3822e0 View commit details
    Browse the repository at this point in the history
  19. empty

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    222b8ee View commit details
    Browse the repository at this point in the history
  20. bring back rc

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    5dda846 View commit details
    Browse the repository at this point in the history
  21. fix rc function builder

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4ba2675 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    63826ef View commit details
    Browse the repository at this point in the history
  23. remove type check revert

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    d9c7aec View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    40e8e77 View commit details
    Browse the repository at this point in the history
  25. remove more master reverst

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c588a9a View commit details
    Browse the repository at this point in the history
  26. bring back removed err

    vezenovm committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    bdfddab View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    dde1831 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Configuration menu
    Copy the full SHA
    a8e428c View commit details
    Browse the repository at this point in the history