-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sync from aztec-packages #4564
Commits on Mar 15, 2024
-
fix: CVC5 api update (AztecProtocol/aztec-packages#5203)
### CVC5 Recently `cvc5` updated their api and changed the way of creating and managing terms. Now `cvc5::TermManger` is responsible for this instead of `cvc5::Solver`. This pr fixes our api to meet their update. Also I made `cvc5` an external project in CMakeLists so now you don't have to install it manually. ### Bool For some reason `Bool` class had pure `cvc5::Solver` pointer as a member. Fixed that to be `smt_solver::Solver`. ### Circuit fixed `univariate_flag`. It was `true` by default, so it performed the wrong optimization. ### Solver renamed - `fp` -> `ff_sort` - `s` -> `solver` - `tm` -> `term_manager` Added placeholder methods `getValue` and `assertFormula` to avoid code like `solver->solver.assertFormula` --------- Co-authored-by: Innokentii Sennovskii <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ac18961 - Browse repository at this point
Copy the full SHA ac18961View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7624f1d - Browse repository at this point
Copy the full SHA 7624f1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cddd78 - Browse repository at this point
Copy the full SHA 3cddd78View commit details -
feat: initial Earthly CI (AztecProtocol/aztec-packages#5069)
Introduces earthly as an alternative CI that hopes to eventually replace our current build-system. https://docs.earthly.dev/ is a build system that combines Makefiles and Dockerfiles. This is basically exactly what our system needed, IMO, and has some nice things figured out. Hope is to reduce complexity of working with the build system by a good chunk. Core changes: - we have a github actions CI that runs a single end to end test inside earthly for arm64 and x86_64 - new Earthfile's now mirror the Dockerfile's, notable differences: - we build our own foundry package for ARM support - we build our own wasi-sdk package for ARM support - grumpkin SRS is no longer generated on the spot, but downloaded like bn254 SRS - we don't inject any commit hashes for Noir as this would cause spurious rebuilds as any difference stops caching, instead we inject a content hash (to be revisited) Side changes: - since we build our own wasi-sdk 21 package, and it is clang18, some compilation workarounds - allow specifying a different nargo and acvm binary in build - small output tweaks --------- Co-authored-by: Charlie Lye <[email protected]> Co-authored-by: Innokentii Sennovskii <[email protected]> Co-authored-by: Cody Gunton <[email protected]> Co-authored-by: Alex Gherghisan <[email protected]> Co-authored-by: Mitchell Tracy <[email protected]> Co-authored-by: Jan Beneš <[email protected]> Co-authored-by: esau <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: josh crites <[email protected]> Co-authored-by: Tom French <[email protected]> Co-authored-by: Álvaro Rodríguez <[email protected]> Co-authored-by: Ilyas Ridhuan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 21b697b - Browse repository at this point
Copy the full SHA 21b697bView commit details -
feat: initial Earthly CI (AztecProtocol/aztec-packages#5069)
Introduces earthly as an alternative CI that hopes to eventually replace our current build-system. https://docs.earthly.dev/ is a build system that combines Makefiles and Dockerfiles. This is basically exactly what our system needed, IMO, and has some nice things figured out. Hope is to reduce complexity of working with the build system by a good chunk. Core changes: - we have a github actions CI that runs a single end to end test inside earthly for arm64 and x86_64 - new Earthfile's now mirror the Dockerfile's, notable differences: - we build our own foundry package for ARM support - we build our own wasi-sdk package for ARM support - grumpkin SRS is no longer generated on the spot, but downloaded like bn254 SRS - we don't inject any commit hashes for Noir as this would cause spurious rebuilds as any difference stops caching, instead we inject a content hash (to be revisited) Side changes: - since we build our own wasi-sdk 21 package, and it is clang18, some compilation workarounds - allow specifying a different nargo and acvm binary in build - small output tweaks --------- Co-authored-by: Charlie Lye <[email protected]> Co-authored-by: Innokentii Sennovskii <[email protected]> Co-authored-by: Cody Gunton <[email protected]> Co-authored-by: Alex Gherghisan <[email protected]> Co-authored-by: Mitchell Tracy <[email protected]> Co-authored-by: Jan Beneš <[email protected]> Co-authored-by: esau <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: josh crites <[email protected]> Co-authored-by: Tom French <[email protected]> Co-authored-by: Álvaro Rodríguez <[email protected]> Co-authored-by: Ilyas Ridhuan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 01631ac - Browse repository at this point
Copy the full SHA 01631acView commit details
Commits on Mar 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c4d62e9 - Browse repository at this point
Copy the full SHA c4d62e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5024f9b - Browse repository at this point
Copy the full SHA 5024f9bView commit details -
chore(avm-simulator): update e2e test (AztecProtocol/aztec-packages#5283
) * Add storage e2e tests * Convert test contract methods to snake case to match other contracts. * Remove `avm_` requirement in function names for transpilation. It's not needed, we rely on `#[aztec(public-vm)]`. * Prepare ground in bootstrap.sh to transpile all files in parallel. It works but I'm being overly cautious and not enabling it on all files until I need it. * Backup original contract before transpiling.
Configuration menu - View commit details
-
Copy full SHA for 3ec0d3d - Browse repository at this point
Copy the full SHA 3ec0d3dView commit details -
chore(avm-simulator): update e2e test (AztecProtocol/aztec-packages#5283
) * Add storage e2e tests * Convert test contract methods to snake case to match other contracts. * Remove `avm_` requirement in function names for transpilation. It's not needed, we rely on `#[aztec(public-vm)]`. * Prepare ground in bootstrap.sh to transpile all files in parallel. It works but I'm being overly cautious and not enabling it on all files until I need it. * Backup original contract before transpiling.
Configuration menu - View commit details
-
Copy full SHA for 73fe3d2 - Browse repository at this point
Copy the full SHA 73fe3d2View commit details