-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: recursion howto explainers #3792
Conversation
🚀 Deployed on https://657c71e602230b26ac6079f0--noir-docs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not following some of the examples you've given. Could you explain a bit more as it's not clear to me why we need to do so many proofs.
Also, I think the recursion interface is going to change soon so technical docs may be out of date soon.
Co-authored-by: Maxim Vezenov <[email protected]>
Co-authored-by: Maxim Vezenov <[email protected]>
Co-authored-by: Maxim Vezenov <[email protected]>
Co-authored-by: josh crites <[email protected]>
Co-authored-by: josh crites <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical stuff looks ok now. I think that we're not being totally clear about why you would use different architectures of recursive proofs however.
Thanks @TomAFrench just made some changes as suggested. Lmk if there's anything else, otherwise let's merge please because there's a bug in master so this needs to go in 0.21.0 |
a47e397
to
c06c7ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the caveats at the top of the How To Guide. That page can still use some improvement, but I think it's ok to ship now and we can iterate on it based on feedback we get. 🚀
Description
This PR also moves things around to accomodate one new
how-to
and its correspondentexplainer
Problem*
An explainer and a guide on recursion was long overdue, but very much needed.
Summary*
It may seem like a lot of files but most of them are just things moving around:
how to
category, I wrote a guide. This also needs to be reviewed@site
were valid... But they route to the assets, thus rendering the page in markdown format 😱 The docusaurus documentation is not entirely clear about that, and I clearly missed the tiny reference to that fact in the advanced pages.