Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Copy on write optimization for brillig #3522

Merged
merged 27 commits into from
Nov 28, 2023
Merged

feat: Copy on write optimization for brillig #3522

merged 27 commits into from
Nov 28, 2023

Commits on Oct 11, 2023

  1. Add element type to Type::Reference

    @jfecher
    jfecher committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e5f46ff View commit details
    Browse the repository at this point in the history

  2. Add inc_rc instruction

    @jfecher
    jfecher committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    13b9319 View commit details
    Browse the repository at this point in the history

  3. Add inc_rc instructions to ssa programs

    @jfecher
    jfecher committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2bafb5d View commit details
    Browse the repository at this point in the history

  4. Implement inc_rc in brillig

    @jfecher
    jfecher committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    946b3e6 View commit details
    Browse the repository at this point in the history

  5. Implement copy on write optimization in brillig

    @jfecher
    jfecher committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    995faa4 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Refactor sections

    @jfecher
    jfecher committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    f32889f View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Fix initial reference count

    @jfecher
    jfecher committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d5c80e0 View commit details
    Browse the repository at this point in the history

  2. Add reference count to extract_registers

    @jfecher
    jfecher committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    cd8be3c View commit details
    Browse the repository at this point in the history

  3. Remove dbg panic

    @jfecher
    jfecher committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d83cf03 View commit details
    Browse the repository at this point in the history

  4. Cleanup branch_instruction

    @jfecher
    jfecher committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    a7727cc View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Start refactor to store rc in the first element of the array

    @jfecher
    jfecher committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    4ef445f View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Add reference type to tests

    @jfecher
    jfecher committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    37654e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. chore: merge master into reference counters

    @sirasistant
    sirasistant committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    edcb040 View commit details
    Browse the repository at this point in the history

  2. revert: set brillig gen to master

    @sirasistant
    sirasistant committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    48806a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. wip: refactor brillig variable vs registerormemory

    @sirasistant
    sirasistant committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    85c63ef View commit details
    Browse the repository at this point in the history

  2. feat: cow optimization

    @sirasistant
    sirasistant committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    58f4699 View commit details
    Browse the repository at this point in the history

  3. test: restore slice tests

    @sirasistant
    sirasistant committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ff526b6 View commit details
    Browse the repository at this point in the history

  4. refactor: typed references

    @sirasistant
    sirasistant committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    4db9468 View commit details
    Browse the repository at this point in the history

  5. test: working on fixing entry point tests

    @sirasistant
    sirasistant committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    a3bf20f View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. test: fix entry point tests

    @sirasistant
    sirasistant committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    48928fa View commit details
    Browse the repository at this point in the history

  2. test: fix dfg test

    @sirasistant
    sirasistant committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    e6afd0d View commit details
    Browse the repository at this point in the history

  3. fix: remove safety check and address todos

    @sirasistant
    sirasistant committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    d8fcb85 View commit details
    Browse the repository at this point in the history

  4. docs: variable naming and comments

    @sirasistant
    sirasistant committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    f5f0c06 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Merge branch 'master' into arv/brillig_reference_counters

    @sirasistant
    sirasistant authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    48e72c9 View commit details
    Browse the repository at this point in the history

  2. chore: formatting

    @sirasistant
    sirasistant committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    9c02007 View commit details
    Browse the repository at this point in the history

  3. revert: cargo lock

    @sirasistant
    sirasistant committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    9be1d2d View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. fix: Fix remaining issues in Brillig's copy on write arrays (#3593) 

    * Remove todo by going with new approach to Rc

* Very important commit: fix typo

* fix: make toBits accept arrays and add test

* fix: always codegen inc_rc

* IncrementRC has no side effects?

* Special case inc_rc instead

* IncRc is actually an even more special case of DIE. Also mark Value::Params as used

* Remove abbreviation

---------

Co-authored-by: sirasistant <[email protected]>
    @jfecher @sirasistant
    jfecher and sirasistant authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2030653 View commit details
    Browse the repository at this point in the history