-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: format integration tests #3002
Conversation
) -> pub [Field; 2] { | ||
) -> pub [Field; 2] | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a bit of an odd choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Could we change this in the formatter?
( | ||
i as u8 + j as u8 + k as u8 + x + y + z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I like the removal of parentheses here. Also one is getting stranded on the previous line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is broken imo. The stranded paren just adds confusion.
if a != 1 { // Change `a` in Prover.toml to test input `b` | ||
if a != 1 { // Change `a` in Prover.toml to test input `b` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct, the other lines are indented by 5
@@ -7,6 +7,5 @@ fn main(arr: [Field; ARRAY_LEN], x: u32) -> pub Field { | |||
value += arr[0 as u32]; | |||
value += arr[1 as Field]; | |||
|
|||
value + (x as Field) | |||
|
|||
value + x as Field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, lack of parentheses make this ambiguous imo.
fyi @f01dab1e (Thank you for the work on the formatter btw!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Test 6" in this file panics. Looks to be something to do with nested for-loops
Description
Problem*
Resolves
Summary*
This PR runs the formatter over the integration test suite to flag up any issues.
6_array
causes a panic due to start>end when slicing.1327_concrete_in_main
)Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.