Allow casting bools to integers (and vice-versa) #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
reviewed
Jul 14, 2022
kevaundray
reviewed
Jul 14, 2022
kevaundray
reviewed
Jul 14, 2022
kevaundray
reviewed
Jul 14, 2022
kevaundray
reviewed
Jul 14, 2022
Merged
* cast bool example * remove proofs folder in example, accidentally committed
jfecher
commented
Jul 15, 2022
|
It's OK for me, I let @kevaundray validate it because it's mostly frontend. |
kevaundray
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #277.
It also turns out we never parsed the bool type either, so I added support for parsing it.
Bool was also the only primitive type not to have constness tracked so I added that as well. Previously if you had a constant and casted it to a boolean and back the compiler would treat it as non-const. Now it will correctly recognize it as still const and allow it to be used as an index.