Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert some unwanted small changes from PR2180 #2685

Merged
merged 1 commit into from
Sep 13, 2023
Merged

chore: revert some unwanted small changes from PR2180 #2685

merged 1 commit into from
Sep 13, 2023

Conversation

guipublic
Copy link
Contributor

Description

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray added this pull request to the merge queue Sep 13, 2023
Merged via the queue into master with commit 1b4823e Sep 13, 2023
15 of 16 checks passed
@kevaundray kevaundray deleted the gd/nit_revert_tests branch September 13, 2023 17:35
TomAFrench added a commit that referenced this pull request Sep 15, 2023
@TomAFrench
Merge branch 'master' into clippy-errors
2ad51e8 
* master:
  chore: Add deprecation message for default type in for loop (#2689)
  chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718)
  chore: clippy fixes (#2719)
  chore: Integrate noir.js into workspace and CI release workflow (#2705)
  feat: Add initial version of noir.js (#2681)
  chore: switch `release-source-resolver.yml` to use yarn (#2704)
  chore: move stranded test to correct directory (#2701)
  chore(ci): deny wildcard dependencies (#2702)
  chore: fix `noirc_abi_wasm` publish for release-please (#2699)
  chore: introduce workspace for js packages (#2677)
  feat: Allow methods defined in a contract to be non-entry points (#2687)
  chore: revert some unwanted small changes from PR2180 (#2685)
  feat(lsp): Add nargo capabilities for test metadata (#2532)
  chore(ci): Add `cargo deny` workflow (#2682)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guipublic @kevaundray