feat(stdlib): grumpkin scalar multiplication API #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I switched the ordering of the function, so that low came first and high came second as this is the "natural" ordering |
kevaundray
reviewed
Sep 7, 2023
kevaundray
reviewed
Sep 7, 2023
|
I've created this issue to track the further work that will be needed: #2588 |
kevaundray
approved these changes
Sep 7, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grumpkin scalar does not fit into the default
Fieldtype and for this reason we can't use thefixed_base_embedded_curvemethod which is already present in the stdlib. Kev advised me to first make a function which takes the fullGrumpkinScalarand callsfixed_base_embedded_curvejust with the high "half" of the grumpkin scalar because so that we have the API ready.