Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Divide by zero should fail to satisfy constraints for Field and ints #2475

Merged
merged 10 commits into from
Aug 29, 2023
Merged

fix: Divide by zero should fail to satisfy constraints for Field and ints #2475

merged 10 commits into from
Aug 29, 2023

Commits on Aug 29, 2023

  1. initial work getting division by 0 to give a constraint failed rather… 

    … than 0 as a result
    @vezenovm
    vezenovm committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    03ab78e View commit details
    Browse the repository at this point in the history

  2. do not simplify with 0 constant

    @vezenovm
    vezenovm committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    3d74590 View commit details
    Browse the repository at this point in the history

  3. remove unnecssary prover toml input

    @vezenovm
    vezenovm committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    777ac3f View commit details
    Browse the repository at this point in the history

  4. remove comments from cargo toml

    @vezenovm
    vezenovm committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    44aba39 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into mv/div-by-zero-fix

    @vezenovm
    vezenovm committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    b3c8697 View commit details
    Browse the repository at this point in the history

  6. merge master

    @vezenovm
    vezenovm committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2ec844e View commit details
    Browse the repository at this point in the history

  7. check for div op when not simplifying for rhs == 0

    @vezenovm
    vezenovm committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    83e95ce View commit details
    Browse the repository at this point in the history

  8. move check for divison by zero to acir gen

    @vezenovm
    vezenovm committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    9ef901b View commit details
    Browse the repository at this point in the history

  9. add comments for why we do not simplify a divison with an rhs of zero

    @vezenovm
    vezenovm committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    be8e1c8 View commit details
    Browse the repository at this point in the history

  10. extra div by zero regression tests

    @vezenovm
    vezenovm committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    28d0453 View commit details
    Browse the repository at this point in the history