Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Require package names to be non-empty #2293

Merged
merged 7 commits into from
Aug 14, 2023
Merged

fix: Require package names to be non-empty #2293

merged 7 commits into from
Aug 14, 2023

Commits on Aug 11, 2023

  1. fix: reject invalid CrateNames in clap

    @TomAFrench
    TomAFrench committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1095700 View commit details
    Browse the repository at this point in the history

  2. chore: reuse FromStr for clap parser

    @TomAFrench
    TomAFrench committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2b12c8e View commit details
    Browse the repository at this point in the history

  3. Update crates/noirc_frontend/src/graph/mod.rs 

    Co-authored-by: Blaine Bublitz <[email protected]>
    @TomAFrench @phated
    TomAFrench and phated authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d86f3fe View commit details
    Browse the repository at this point in the history

  4. chore: use implicit CrateName parser

    @TomAFrench
    TomAFrench committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c702838 View commit details
    Browse the repository at this point in the history

  5. include invalid names with better error messages for invalid names in… 

    … nargo.toml
    @phated
    phated committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b67dedb View commit details
    Browse the repository at this point in the history

  6. properly catch file paths that would make invalid package names

    @phated
    phated committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    64822f7 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. chore: add tests for compiling invalid package names

    @TomAFrench
    TomAFrench committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    4f1e2a1 View commit details
    Browse the repository at this point in the history