Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typecheck unit type #1956

Closed
wants to merge 1 commit into from
Closed

chore: fix typecheck unit type #1956

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 18, 2023

Description

fix typecheck unit type

Problem

Resolves #1933

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

jfecher
jfecher requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better fixed by changing the parser rather than the steps afterward

@jfecher jfecher mentioned this pull request Jul 18, 2023
Merged
5 tasks
@jfecher
Copy link
Contributor

jfecher commented Jul 18, 2023

Made a PR here #1960

@jfecher jfecher closed this Jul 18, 2023
@ghost ghost deleted the unit-type branch July 18, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expression without assignment is incorrectly typechecked
1 participant
@jfecher