Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nargo): Allow user-specified file for prover inputs instead of Prover.toml #1531

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

exp-table
Copy link
Contributor

Description

A short modification of nargo_cli to allow the user to specify which .toml file to use when generating a proof instead of being forced to use Prover.toml.

Problem*

The user had no choice but to use Prover.toml when generating a proof.
This is leading to race conditions when running forge tests (which run in parallel), in particular when these tests use on-the-fly proof generation.

Summary*

Allows the user to optionnally specify which .toml file to use with the -p or --prover-name flag.

This PR sets out to

Example

Before:

nargo prove p

After:

nargo prove -p OtherProver pp 

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench self-requested a review June 5, 2023 04:25
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working through a notification backlog today so will do a more thorough review later on.

crates/nargo_cli/src/cli/prove_cmd.rs Outdated Show resolved Hide resolved
crates/nargo_cli/src/cli/prove_cmd.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench changed the title feat(nargo prove): allows to specify any toml file instead of Prover.toml feat(nargo): Allow user-specified file for prover inputs instead of Prover.toml Jun 5, 2023
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exp-table
Copy link
Contributor Author

need te re-run failed action I believe

@exp-table exp-table requested a review from jfecher June 7, 2023 14:22
@exp-table
Copy link
Contributor Author

LFG

@TomAFrench
Copy link
Member

Thanks for this @exp-table!

@TomAFrench TomAFrench added this pull request to the merge queue Jun 7, 2023
Merged via the queue into noir-lang:master with commit 91cbec6 Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants