Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clarify that verify_signature takes a hashed message #1365

Merged
merged 1 commit into from
May 18, 2023
Merged

chore: clarify that verify_signature takes a hashed message #1365

merged 1 commit into from
May 18, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Motivated by slack messages

Description

Summary of changes

This updates the argument name in the verify_signature function to specify that it receives the hash of the message rather than the message itself.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

kevaundray
kevaundray approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One annoyance is that barretenberg in particular has a quirk where the message_hash needs to be 32 bytes. So for barretenberg, one can only use sha256, blake2s and keccak256.

This is not a limitation of the ECDSA algorithm, just in barretenberg

@TomAFrench TomAFrench added this pull request to the merge queue May 17, 2023
Merged via the queue into master with commit cfbc1f7 May 18, 2023
@TomAFrench TomAFrench deleted the update-ecdsa-func-signature branch May 18, 2023 00:02
TomAFrench added a commit that referenced this pull request May 18, 2023
@TomAFrench
Merge branch 'master' into mv/opcode_supported
d1ec8d2 
* master:
  fix: Fix modulo operator for comptime values (#1361)
  chore: clarify that `verify_signature` takes a hashed message (#1365)
  feat: pass in closure to `Driver` to signal backend opcode support (#1349)
  feat(nargo)!: retire print-acir in favour of flag (#1328)
  chore(ssa): enable cse for assert (#1350)
  chore(ssa refactor): Add basic instruction simplification (#1329)
  chore(noir): Release 0.6.0 (#1279)
TomAFrench added a commit that referenced this pull request May 18, 2023
@TomAFrench
Merge branch 'master' into phated/ref-string
2ac6352 
* master:
  fix: Fix modulo operator for comptime values (#1361)
  chore: clarify that `verify_signature` takes a hashed message (#1365)
  feat: pass in closure to `Driver` to signal backend opcode support (#1349)
  feat(nargo)!: retire print-acir in favour of flag (#1328)
  chore(ssa): enable cse for assert (#1350)
  chore(ssa refactor): Add basic instruction simplification (#1329)
  chore(noir): Release 0.6.0 (#1279)
TomAFrench added a commit that referenced this pull request May 18, 2023
@TomAFrench
Merge branch 'master' into phated/acvm-0.12.0
fc9df35 
* master:
  fix: Fix modulo operator for comptime values (#1361)
  chore: clarify that `verify_signature` takes a hashed message (#1365)
  feat: pass in closure to `Driver` to signal backend opcode support (#1349)
  feat(nargo)!: retire print-acir in favour of flag (#1328)
  chore(ssa): enable cse for assert (#1350)
  chore(ssa refactor): Add basic instruction simplification (#1329)
  chore(noir): Release 0.6.0 (#1279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @kevaundray