Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move allow(dead_code) to only cover CyclicDependenciesError #1093

Merged
merged 1 commit into from
Apr 4, 2023
Merged

chore: move allow(dead_code) to only cover CyclicDependenciesError #1093

merged 1 commit into from
Apr 4, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves #119

Description

Summary of changes

I've restricted the lint to only cover CyclicDependenciesError as this is the only instance of dead code. We should consolidate the crate graph and resolver code at some point at which we can remove this dead code.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray added this pull request to the merge queue Apr 4, 2023
Merged via the queue into master with commit dc77fa6 Apr 4, 2023
@kevaundray kevaundray deleted the dead-code-lint branch April 4, 2023 18:31
TomAFrench added a commit that referenced this pull request Apr 5, 2023
@TomAFrench
Merge branch 'master' into fast-checksum
4564967 
* master:
  feat: Changes serialization for contract functions (#1056)
  chore: move `allow(dead_code)` to only cover `CyclicDependenciesError` (#1093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate all instances of #![allow(dead_code)]
2 participants
@TomAFrench @kevaundray