Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement to_be_radix builtin in the comptime interpreter #6042

Closed
Thunkar opened this issue Sep 16, 2024 · 1 comment · Fixed by #6043
Closed

Implement to_be_radix builtin in the comptime interpreter #6042

Thunkar opened this issue Sep 16, 2024 · 1 comment · Fixed by #6043
Labels
enhancement New feature or request

Comments

@Thunkar
Copy link
Contributor

Thunkar commented Sep 16, 2024

Problem

That intrinsic is missing from the comptime interpreter

Happy Case

to_be_radix can be used on a Field type in comptime

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

Blocker

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@Thunkar Thunkar added the enhancement New feature or request label Sep 16, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 16, 2024
@TomAFrench
Copy link
Member

Implemented here but this can be worked around by reversing in Noir for the time being now that it returns an array rather than a slice.

github-merge-queue bot pushed a commit that referenced this issue Sep 16, 2024
# Description

## Problem\*

Resolves #6042
## Summary\*

This PR implements `to_be_radix` in the comptime interpreter by reusing
our impl for `to_le_radix`.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants