Quoted Exprs from blocks fail to parse back into expressions
#6036
Labels
bug
Something isn't working
Comments
jfecher
changed the title
Exprs fail to parse back into expressionsExprs from blocks fail to parse back into expressions
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 13, 2024
# Description ## Problem\* Resolves #6036 ## Summary\* Grego was having an issue from some macros where some code was taken from a block and later put in the rhs of a `let` statement: `let _ = $former_block_statement`. Since this expression originated from a block statement though, it is a `Token::InternedStatement` and not a valid expression. I've updated the parser to accept interned statements in an expression position, and we just later validate that they're either `StatementKind::Expression` or `StatementKind::Semi` nodes. ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Aim
Quote an expression from a block expression, add it to a quote, unquote the whole thing as a new expression.
This is because the expression is an
InternedStatementinternallyExpected Behavior
The above should work
Bug
Compiler fails to parse the Expr:
Parsed expr Err(FailedToParseMacro {
error: ParserError { expected_tokens: {}, expected_labels: {Expression}, found: InternedStatement(InternedStatementKind(Index(0)))
To Reproduce
Workaround
None
Workaround Description
No response
Additional Context
No response
Project Impact
Blocker
Blocker Context
No response
Nargo Version
No response
NoirJS Version
No response
Proving Backend Tooling & Version
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: