Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding fields to structs in comptime #5911

Closed
Thunkar opened this issue Sep 4, 2024 · 0 comments · Fixed by #5931
Closed

Allow adding fields to structs in comptime #5911

Thunkar opened this issue Sep 4, 2024 · 0 comments · Fixed by #5931
Labels
enhancement New feature or request

Comments

@Thunkar
Copy link
Contributor

Thunkar commented Sep 4, 2024

Problem

Currently it's only possible to get the fields of a struct via struct_definition.fields()

Happy Case

Something like this exists:

comptime fn add_fields(s: StructDefinition) {
  let fields:  [(Quote, Type)] = [...];
  s.set_fields(fields);
}

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

Blocker

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@Thunkar Thunkar added the enhancement New feature or request label Sep 4, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 4, 2024
@jfecher jfecher mentioned this issue Sep 4, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 5, 2024
@jfecher @asterite
feat: Add StructDefinition::set_fields (#5931)
9d2629d 
# Description

## Problem\*

Resolves #5911

## Summary\*

Adds a function to set the fields on a struct type

## Additional Context

Hyper-specific error messages can be fun. Here's the error issued when
one of the field names isn't a valid identifier:

```
error: Quoted value in index 1 of this slice is not a valid field name
   ┌─ src/main.nr:25:18
   │
25 │     s.set_fields(fields);
   │                  ------ `quote { foo bar }` is not a valid field name for `set_fields`
   │
```

## Documentation\*

Check one:
- [ ] No documentation needed.
- [x] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Ary Borenszweig <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add StructDefinition::set_fields noir-lang/noir
1 participant
@Thunkar