Add Module::add_item

[jfecher]

Problem

(From a slack request)

Given just a Module metaprogramming object, there is no way to add additional functions or types to the module.

Happy Case

We add the function:

impl Module {
    fn add_item(self, item: Quoted) {}
}

To add a top-level item to the module.

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

[asterite]

I was actually wondering if this should be the only way to add new items to a program.

For example, if you have two annotations on a module:

#[one]
mod foo {
  #![two]
}

if there are functions one and two that return a Quoted value, where do they get inserted? I think right now for one it's inserted in foo's parent, but for two it's inserted in foo... but maybe that's expected?

[jfecher]

@asterite I think I would expect both to be inserted within foo. We should have inner attributes just be a syntax thing that are otherwise equivalent to being on the module itself.

[asterite]

Sounds good, I'll capture an issue for this and likely work on it today.