Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a compile-time hashmap type #5479

Closed
Tracked by #4594
jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5543
Closed
Tracked by #4594

Add a compile-time hashmap type #5479

jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5543
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Jul 10, 2024

Problem

A HashMap is a useful container type but constrained Noir is limited to std::collections::HashMap which can be slow and limiting in a comptime context where a Turing-complete context is available.

Happy Case

Add a CtHashMap type which can grow and shrink as needed and can use break when finding an element.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the enhancement New feature or request label Jul 10, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 10, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 18, 2024
# Description

## Problem\*

Resolves #5479

## Summary\*

Mostly copied over from our existing hash map with a few changes.
- Uses slices and grows automatically
- Uses `break`

## Additional Context

Like other comptime code, I'm avoiding documenting this until comptime
as a whole is stable

## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [x] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Michael J Klein <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant