nargo fmt crashes with "not formatted because a comment would be lost"
#4980
Labels
bug
Something isn't working
Comments
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 24, 2024
# Description ## Problem Resolves #4980 ## Summary In reality the new formatter didn't crash anymore, it just formatted this: ```noir fn foo() { let x = 1 // one + 2 // two + 3; // three } ``` like this: ```noir fn foo() { let x = 1 // one + 2 // two + 3; // three } ``` but making it look like the first snippet was easy, so here's that PR :-) ## Additional Context ## Documentation Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Aim
I tried to format aztec protocol circuits and the formatter crashed on this line with:
To make it all succeed I commented out that specific line which caused issue and then uncommented it after the formatting was done.
Expected Behavior
It should not crash.
Bug
To Reproduce
nargo fmtProject Impact
None
Impact Context
No response
Workaround
None
Workaround Description
No response
Additional Context
No response
Installation Method
None
Nargo Version
0.28.0+866c3cd46fbb68f5698800aa4c31459487e820ac
NoirJS Version
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: