Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call generic functions in a comptime context #4924

Closed
Tracked by #4594
jfecher opened this issue Apr 25, 2024 · 0 comments · Fixed by #5330
Closed
Tracked by #4594

Call generic functions in a comptime context #4924

jfecher opened this issue Apr 25, 2024 · 0 comments · Fixed by #5330
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Apr 25, 2024

Problem

Normally executing generic functions is only done after monomorphization but the comptime interpreter will need to be able to evaluate them without monomorphizing them first.

Happy Case

fn main() {
    let three = comptime { id(3) };
}

fn id<T>(x: T) -> T { x }

Works along with other generic functions

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the enhancement New feature or request label Apr 25, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 26, 2024
# Description

## Problem\*

Resolves #4924

## Summary\*

Implements the calling of generic functions in the interpreter

## Additional Context

I've removed the "type_check" method entirely since it was causing
errors. Certain types wouldn't match up (even with `follow_bindings`). I
couldn't fix this so I removed it since it is duplicated work from type
checking anyway.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant