Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brilliw COW optimization regression #4332

Closed
sirasistant opened this issue Feb 12, 2024 · 0 comments · Fixed by #4333
Closed

Brilliw COW optimization regression #4332

sirasistant opened this issue Feb 12, 2024 · 0 comments · Fixed by #4333
Labels
bug Something isn't working

Comments

@sirasistant
Copy link
Contributor

Aim

After #4210 the cow optimization seems to not be in effect in a critical codepath in aztec-packages protocol circuits

Expected Behavior

Should run

Bug

Tries to copy on all operations so execution never ends

To Reproduce

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

None

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@sirasistant sirasistant added the bug Something isn't working label Feb 12, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 12, 2024
This was referenced Feb 12, 2024
Merged
Closed
github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2024
@sirasistant
fix: Revert "correct result when assigning shared arrays" and added r…
05e78b3 
…egression test (#4333)

# Description

## Problem\*

Resolves: #4332

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 12, 2024
@jfecher jfecher mentioned this issue Mar 4, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 11, 2024
@jfecher
fix: Fix brillig slowdown when assigning arrays in loops (#4472)
2a53545 
# Description

## Problem\*

Resolves #3795

## Summary\*

This is an older version of #4210
which undoes the change in
d331ee2
due to a regression #4332.

This PR is not yet confirmed to work since I do not have a test case for
it! @sirasistant, do you mind seeing if this fixes the regression issue?

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Revert "correct result when assigning shared arrays" and added regression test noir-lang/noir
1 participant
@sirasistant