Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the BN254 field comparison library #4138

Closed
Savio-Sou opened this issue Jan 23, 2024 · 0 comments · Fixed by #4311
Closed

Document the BN254 field comparison library #4138

Savio-Sou opened this issue Jan 23, 2024 · 0 comments · Fixed by #4311
Assignees
@sirasistant
Labels
documentation Improvements or additions to documentation
Milestone
0.23

Comments

@Savio-Sou
Copy link
Collaborator

Document bn254.nr.

Reference: #4042
@Savio-Sou Savio-Sou added this to the 0.23 milestone Jan 23, 2024
@Savio-Sou Savio-Sou added this to Noir Jan 23, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 23, 2024
@Savio-Sou Savio-Sou added the documentation Improvements or additions to documentation label Jan 24, 2024
@sirasistant sirasistant mentioned this issue Feb 9, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 9, 2024
@sirasistant
chore: Document bn254 lib (#4311)
da4e86f 
# Description

## Problem\*

Resolves #4138

## Summary\*

Add some small docs and add code comments to explain the not-obvious
checks.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [x] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
documentation Improvements or additions to documentation
Projects
Noir
Archived in project
Milestone
0.23
Development

Successfully merging a pull request may close this issue.

chore: Document bn254 lib noir-lang/noir
2 participants
@sirasistant @Savio-Sou