Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECADD and ECDOUBLE opcodes for embedded curve into ACIR #3958

Closed
kevaundray opened this issue Jan 4, 2024 · 0 comments
Closed

Add ECADD and ECDOUBLE opcodes for embedded curve into ACIR #3958

kevaundray opened this issue Jan 4, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@kevaundray
Copy link
Contributor

Problem

Currently we have a fixed base scalar mul opcode for the embedded curve, however some applications like El-Gamal require grup operations.

We can remove the scalar mul opcode in place of group operations (ECADD and ECDOUBLE) and then implement scalar multiplication in terms of those opcodes.

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added enhancement New feature or request P-MEDIUM labels Jan 4, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 4, 2024
guipublic added a commit to AztecProtocol/aztec-packages that referenced this issue Jan 9, 2024
Please provide a paragraph or two giving a summary of the change,
including relevant motivation and context.

Related to  noir-lang/noir#3958

This PR does not implements the opcodes, but modifies BB interface so
that it accept the new opcodes.
It also does not implement the solver for the opcodes.


# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [X] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [X] Every change is related to the PR description.
- [X] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: Tom French <[email protected]>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Jan 10, 2024
Please provide a paragraph or two giving a summary of the change,
including relevant motivation and context.

Related to  noir-lang/noir#3958

This PR does not implements the opcodes, but modifies BB interface so
that it accept the new opcodes.
It also does not implement the solver for the opcodes.


# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [X] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [X] Every change is related to the PR description.
- [X] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: Tom French <[email protected]>
@kevaundray kevaundray added this to the 1.0 milestone Jan 15, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 20, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
Please provide a paragraph or two giving a summary of the change,
including relevant motivation and context.

Related to  noir-lang/noir#3958

This PR does not implements the opcodes, but modifies BB interface so
that it accept the new opcodes.
It also does not implement the solver for the opcodes.


# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [X] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [X] Every change is related to the PR description.
- [X] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: Tom French <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants