Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): goto struct definition from local reference #3720

Closed
Tracked by #1574
kobyhallx opened this issue Dec 8, 2023 · 0 comments
Closed
Tracked by #1574

feat(lsp): goto struct definition from local reference #3720

kobyhallx opened this issue Dec 8, 2023 · 0 comments
Assignees

Comments

@kobyhallx
Copy link
Contributor

kobyhallx commented Dec 8, 2023

Considering

struct Pair {
    first: Field,
    second: Field,
}

impl Pair {

    fn bar(self) -> Field {
        self.first
    }
}

fn main() {

    let p = Pair { first: 1, second: 1 };

    assert(p.bar() == 1);
}

Chosing Goto Type Definition options while at symbol p of line assert(p.bar() == 1); should take user to first line struct Pair {.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 8, 2023
@kobyhallx kobyhallx changed the title feat(lsp): goto struct definition from locat reference feat(lsp): goto struct definition from local reference Dec 8, 2023
@kobyhallx kobyhallx self-assigned this Jan 15, 2024
@kobyhallx kobyhallx moved this from 📋 Backlog to 🏗 In progress in Noir Jan 15, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2024
# Description

## Problem\*

Resolves <!-- Link to GitHub Issue -->

feat(lsp): goto struct definition from local reference #3720

## Summary\*

Go to definition of type.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant