Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blake3 opcode into ACIR #3171

Closed
kevaundray opened this issue Oct 16, 2023 · 0 comments · Fixed by AztecProtocol/aztec-packages#3856
Closed

Add blake3 opcode into ACIR #3171

kevaundray opened this issue Oct 16, 2023 · 0 comments · Fixed by AztecProtocol/aztec-packages#3856
Labels
ACIR/ACVM aztec.nr Helpful for development of Aztec.nr the smart contract framework enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

Currently we have a blake2 opcode, though blake3 is considered more secure than blake2 -- it is already in the barretenberg standard library, so the added lines of code will be the same as blake2 and sha256.

Happy Case

Add blake3 opcode into ACIR

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added enhancement New feature or request ACIR/ACVM aztec.nr Helpful for development of Aztec.nr the smart contract framework labels Oct 16, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 16, 2023
@kevaundray kevaundray mentioned this issue Oct 16, 2023
Open
@TomAFrench TomAFrench mentioned this issue Oct 16, 2023
Closed
1 task
@TomAFrench TomAFrench mentioned this issue Oct 23, 2023
Closed
5 tasks
@TomAFrench TomAFrench mentioned this issue Jan 5, 2024
Merged
4 tasks
kevaundray pushed a commit to AztecProtocol/aztec-packages that referenced this issue Jan 5, 2024
@TomAFrench
feat!: add blake3 blackbox function to acir format (#3856)
8c96d4c 
Resolves noir-lang/noir#3171

We've started adding breaking changes to the serialisation so I thought
I'd chuck this in.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ACIR/ACVM aztec.nr Helpful for development of Aztec.nr the smart contract framework enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
2 participants
@TomAFrench @kevaundray