-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push nightly builds of wasm
crate to noir_wasm
repository.
#2210
Labels
enhancement
New feature or request
Comments
5 tasks
Transferring to @kobyhallx as he's said he's doing monorepo-ing work next week. |
spalladino
added a commit
to AztecProtocol/aztec-packages
that referenced
this issue
Aug 15, 2023
Exposes a Noir contract compiler to end users via the CLI. Adds a new `compile` command in the aztec-cli, also exposed via the `noir-compiler` package as `aztec-compile contract`. This command compiles a noir contract using nargo or noir-wasm (defaulting to nargo until noir-lang/noir#2210 is fixed), then reformats it for Aztec consumption, and optionally generates typescript wrappers and noir interfaces. All these actions are also exported as functions from the `noir-compiler` package, and are now used in the `copy-output` script. This PR also makes a few changes to the generated typescript type: `create` gets renamed to `at` (to make it clear we're not creating a new contract but creating an instance of the ts wrapper for a contract at an address) and the import path to the ABI is directly to the JSON file. We could add more (sub)commands just for generating the typescript or noir interfaces from the CLI, so it can be used in flows where nargo is used directly. We should also update the project README and add a page in the docs about how to compile one's own contracts (not sure if there's already one in the skeleton). Fixes #1457
AztecBot
pushed a commit
to AztecProtocol/docs
that referenced
this issue
Aug 15, 2023
Exposes a Noir contract compiler to end users via the CLI. Adds a new `compile` command in the aztec-cli, also exposed via the `noir-compiler` package as `aztec-compile contract`. This command compiles a noir contract using nargo or noir-wasm (defaulting to nargo until noir-lang/noir#2210 is fixed), then reformats it for Aztec consumption, and optionally generates typescript wrappers and noir interfaces. All these actions are also exported as functions from the `noir-compiler` package, and are now used in the `copy-output` script. This PR also makes a few changes to the generated typescript type: `create` gets renamed to `at` (to make it clear we're not creating a new contract but creating an instance of the ts wrapper for a contract at an address) and the import path to the ABI is directly to the JSON file. We could add more (sub)commands just for generating the typescript or noir interfaces from the CLI, so it can be used in flows where nargo is used directly. We should also update the project README and add a page in the docs about how to compile one's own contracts (not sure if there's already one in the skeleton). Fixes #1457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
https://github.com/noir-lang/noir_wasm is out of date compared to this repository.
Happy Case
We're currently building the wasm package on each commit. We can draw from this to create a workflow to push a new commit to https://github.com/noir-lang/noir_wasm at night with the latest build of the
wasm
crate.https://github.com/noir-lang/noir_wasm has a pull workflow for this which we can turn into a push workflow.
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: