-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(crates): do not process relative dependencies twice #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maddiaa0
force-pushed
the
md/fix-circ-deps
branch
from
July 4, 2023 09:49
91ea967
to
aec1e89
Compare
ludamad
reviewed
Jul 4, 2023
Maddiaa0
force-pushed
the
md/fix-circ-deps
branch
from
July 4, 2023 13:25
389e66e
to
21d4132
Compare
jfecher
reviewed
Jul 4, 2023
jfecher
reviewed
Jul 4, 2023
Looks like |
jfecher
reviewed
Jul 4, 2023
jfecher
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I believe this broke wasm because (last time I checked) the canonicalize function is not supported by wasi. I had replaced this in circom with an alternative impl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in the aztec3 repo we are unable to import helper dependencies that rely on the
aztec3-noir
standard library that we have created.The module structure is something like this:
in our case both helper depends on library and helper, where helper also depends on library. This leads to noir compiling the library files, then recompiling them when processing the helper.
This leads to instances like below, where the same type has two different idents that mismatch.
This pr fixes this issue by recognising when a dependant local crate has already been compiled, and not compiling it again
Problem*
Resolves
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.