Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path canonicalize doesn't have an implementation in wasm #1869

Closed
phated opened this issue Jul 5, 2023 · 0 comments · Fixed by #1881
Closed

Path canonicalize doesn't have an implementation in wasm #1869

phated opened this issue Jul 5, 2023 · 0 comments · Fixed by #1881
Labels
bug Something isn't working

Comments

@phated
Copy link
Contributor

phated commented Jul 5, 2023

Aim

FileManager should be able to work in WASM

Expected Behavior

Nothing is thrown in WASM

Bug

As of the last time I checked, there was no implementation of canonicalize for Rust paths in WASM. Since it is being used in #1856, I believe the wasm build will be broken.

To Reproduce

Installation Method

None

Nargo Version

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@phated phated added the bug Something isn't working label Jul 5, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 5, 2023
@phated phated mentioned this issue Jul 6, 2023
Merged
5 tasks
@Savio-Sou Savio-Sou moved this from 📋 Backlog to 🏗 In progress in Noir Jul 13, 2023
This was referenced Jul 17, 2023
Closed
Closed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Create FileManager with a root and normalize filenames against it noir-lang/noir
1 participant
@phated