Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(acir_gen): More granular element sizes array check (#4528)
# Description ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* The `array_typ.contains_slice_element()` check in `can_omit_element_sizes_array` is incorrect. This should have been `is_nested_slice()` but we already banned nested slices so I just removed it. This leads to improvements for slices in general so I have made it a separate PR. This was also a blocker for #4523. When working with `AsSlice` we would omit the element sizes array. When it came time to access a slice created with `as_slice()` we would attempt to use the element sizes array which was never initialized correctly and we would go out of bounds. ## Additional Context ## Documentation\* Check one: - [X] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [X] I have tested the changes locally. - [X] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
- Loading branch information