Skip to content

Commit

Permalink
chore(ci): enforce timeouts on build and test workflows (#3804)
Browse files Browse the repository at this point in the history
# Description

## Problem\*

Resolves <!-- Link to GitHub Issue -->

## Summary\*

This PR adds a timeout to all of the jobs which are likely to spin out
for a long time.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
  • Loading branch information
TomAFrench authored Dec 14, 2023
1 parent 57d2505 commit f1aa928
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/publish-nargo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
strategy:
matrix:
target: [x86_64-apple-darwin, aarch64-apple-darwin]
timeout-minutes: 30

steps:
- name: Checkout
Expand Down Expand Up @@ -120,6 +121,7 @@ jobs:
fail-fast: false
matrix:
target: [x86_64-unknown-linux-gnu, x86_64-unknown-linux-musl]
timeout-minutes: 30

steps:
- name: Checkout
Expand Down
17 changes: 14 additions & 3 deletions .github/workflows/test-js-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ concurrency:
jobs:
build-nargo:
runs-on: ubuntu-22.04
timeout-minutes: 30

steps:
- name: Checkout Noir repo
Expand Down Expand Up @@ -47,6 +48,7 @@ jobs:

build-noir-wasm:
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- name: Checkout sources
Expand Down Expand Up @@ -76,6 +78,8 @@ jobs:

build-acvm-js:
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand Down Expand Up @@ -103,6 +107,7 @@ jobs:

build-noirc-abi:
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- name: Checkout sources
Expand Down Expand Up @@ -133,6 +138,7 @@ jobs:
needs: [build-acvm-js]
name: ACVM JS (Node.js)
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- name: Checkout sources
Expand All @@ -154,6 +160,7 @@ jobs:
needs: [build-acvm-js]
name: ACVM JS (Browser)
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- name: Checkout sources
Expand All @@ -180,6 +187,7 @@ jobs:
needs: [build-noirc-abi]
name: noirc_abi
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- name: Checkout sources
Expand Down Expand Up @@ -265,12 +273,12 @@ jobs:
yarn workspace @noir-lang/noir_js build
yarn workspace @noir-lang/noir_js test

test-noir-wasm:
needs: [build-noir-wasm, build-nargo]
name: noir_wasm
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand Down Expand Up @@ -314,6 +322,8 @@ jobs:
needs: [build-acvm-js, build-noirc-abi]
name: noir_codegen
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -346,7 +356,8 @@ jobs:
name: Integration Tests
runs-on: ubuntu-latest
needs: [build-acvm-js, build-noir-wasm, build-nargo, build-noirc-abi]

timeout-minutes: 30

steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down

0 comments on commit f1aa928

Please sign in to comment.