Satisfy Clippy

noir-lang · Jan 30, 2024 · 0c22691 · 0c22691
1 parent 16689ee
commit 0c22691
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 15 deletions.
diff --git a/compiler/noirc_evaluator/src/ssa/function_builder/mod.rs b/compiler/noirc_evaluator/src/ssa/function_builder/mod.rs
@@ -494,21 +494,16 @@ impl FunctionBuilder {
                 // This is a bit odd, but in brillig the inc_rc instruction operates on
                 // a copy of the array's metadata, so we need to re-store a loaded array
                 // even if there have been no other changes to it.
-                match &self.current_function.dfg[value] {
-                    Value::Instruction { instruction, .. } => {
-                        match &self.current_function.dfg[*instruction] {
-                            Instruction::Load { address } => {
-                                // We can't re-use `value` in case the original address was stored
-                                // to again in the meantime. So introduce another load.
-                                let address = *address;
-                                let value = self.insert_load(address, typ);
-                                self.insert_instruction(Instruction::IncrementRc { value }, None);
-                                self.insert_store(address, value);
-                            }
-                            _ => (),
-                        }
+                if let Value::Instruction { instruction, .. } = &self.current_function.dfg[value] {
+                    let instruction = &self.current_function.dfg[*instruction];
+                    if let Instruction::Load { address } = instruction {
+                        // We can't re-use `value` in case the original address was stored
+                        // to again in the meantime. So introduce another load.
+                        let address = *address;
+                        let value = self.insert_load(address, typ);
+                        self.insert_instruction(Instruction::IncrementRc { value }, None);
+                        self.insert_store(address, value);
                     }
-                    _ => (),
                 }
             }
         }

diff --git a/compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs b/compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs
@@ -680,7 +680,7 @@ impl<'a> FunctionContext<'a> {
 
         rhs.clone().for_each(|value| {
             let value = value.eval(self);
-            self.builder.increment_array_reference_count(value)
+            self.builder.increment_array_reference_count(value);
         });
 
         self.assign_new_value(lhs, rhs);