fix(frontend): Add type check for constant bit shift overflows #7350
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name: Wasm | |
on: | |
pull_request: | |
merge_group: | |
concurrency: | |
group: ${{ github.workflow }}-${{ github.head_ref || github.ref || github.run_id }} | |
cancel-in-progress: true | |
jobs: | |
# TODO: Replace this step with downloading a wasm binary from a set release of Barretenberg | |
build-barretenberg: | |
runs-on: ubuntu-latest | |
steps: | |
- name: Checkout Noir repo | |
uses: actions/checkout@v3 | |
- name: Collect locked barretenberg rev | |
run: | | |
echo "BB_REV=$(jq -r .nodes.barretenberg.locked.rev ./flake.lock)" >> $GITHUB_ENV | |
echo "BB_REV is ${{ env.BB_REV }}" | |
- uses: cachix/install-nix-action@v20 | |
with: | |
nix_path: nixpkgs=channel:nixos-22.11 | |
github_access_token: ${{ secrets.GITHUB_TOKEN }} | |
- uses: cachix/cachix-action@v12 | |
with: | |
name: barretenberg | |
authToken: "${{ secrets.CACHIX_AUTH_TOKEN }}" | |
# Upload does not work with symlinks, using this workaround: | |
# https://github.com/actions/upload-artifact/issues/92#issuecomment-1080347032 | |
- name: Build barretenberg as libbarretenberg-wasm32 | |
run: | | |
echo "BB_REV is ${{ env.BB_REV }}" | |
nix build "github:AztecProtocol/barretenberg/${{ env.BB_REV }}#wasm32" | |
echo "ARTIFACT_UPLOAD_PATH=$(readlink -f result)" >> $GITHUB_ENV | |
- name: Upload artifact | |
uses: actions/upload-artifact@v3 | |
with: | |
name: libbarretenberg-wasm32 | |
path: ${{ env.ARTIFACT_UPLOAD_PATH }} | |
retention-days: 3 | |
build-nargo: | |
needs: [build-barretenberg] | |
runs-on: ubuntu-22.04 | |
env: | |
CACHED_PATHS: | | |
~/.cargo/bin/ | |
~/.cargo/registry/index/ | |
~/.cargo/registry/cache/ | |
~/.cargo/git/db/ | |
target/ | |
steps: | |
- name: Checkout Noir repo | |
uses: actions/checkout@v3 | |
- uses: actions/cache/restore@v3 | |
id: cache | |
with: | |
path: ${{ env.CACHED_PATHS }} | |
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} | |
- name: Download artifact | |
uses: actions/download-artifact@v3 | |
with: | |
name: libbarretenberg-wasm32 | |
path: ${{ github.workspace }}/libbarretenberg-wasm32 | |
- name: Setup toolchain | |
uses: dtolnay/[email protected] | |
- name: Build Nargo | |
env: | |
BARRETENBERG_BIN_DIR: ${{ github.workspace }}/libbarretenberg-wasm32/bin | |
run: | | |
cargo build --package nargo_cli --release --no-default-features --features plonk_bn254_wasm | |
- uses: actions/cache/save@v3 | |
# Don't create cache entries for the merge queue. | |
if: ${{ steps.cache.outputs.cache-hit != 'true' && github.event_name != 'merge_group' }} | |
with: | |
path: ${{ env.CACHED_PATHS }} | |
key: ${{ steps.cache.outputs.cache-primary-key }} | |
- name: Package artifacts | |
run: | | |
mkdir dist | |
cp ./target/release/nargo ./dist/nargo | |
7z a -ttar -so -an ./dist/* | 7z a -si ./nargo-x86_64-unknown-linux-gnu.tar.gz | |
- name: Upload artifact | |
uses: actions/upload-artifact@v3 | |
with: | |
name: nargo | |
path: ./dist/* | |
retention-days: 3 | |
build-wasm: | |
runs-on: ubuntu-latest | |
env: | |
CACHED_PATH: /tmp/nix-cache | |
steps: | |
- name: Checkout sources | |
uses: actions/checkout@v3 | |
- name: Setup Nix | |
uses: cachix/install-nix-action@v22 | |
with: | |
nix_path: nixpkgs=channel:nixos-22.11 | |
github_access_token: ${{ secrets.GITHUB_TOKEN }} | |
- name: Restore nix store cache | |
uses: actions/cache/restore@v3 | |
id: cache | |
with: | |
path: ${{ env.CACHED_PATH }} | |
key: ${{ runner.os }}-flake-wasm-${{ hashFiles('*.lock') }} | |
# Based on https://github.com/marigold-dev/deku/blob/b5016f0cf4bf6ac48db9111b70dd7fb49b969dfd/.github/workflows/build.yml#L26 | |
- name: Copy cache into nix store | |
if: steps.cache.outputs.cache-hit == 'true' | |
# We don't check the signature because we're the one that created the cache | |
run: | | |
for narinfo in ${{ env.CACHED_PATH }}/*.narinfo; do | |
path=$(head -n 1 "$narinfo" | awk '{print $2}') | |
nix copy --no-check-sigs --from "file://${{ env.CACHED_PATH }}" "$path" | |
done | |
- name: Build wasm package | |
run: | | |
nix build -L .#wasm | |
- name: Export cache from nix store | |
if: ${{ steps.cache.outputs.cache-hit != 'true' && github.event_name != 'merge_group' }} | |
run: | | |
nix copy --to "file://${{ env.CACHED_PATH }}?compression=zstd¶llel-compression=true" .#noir-wasm-cargo-artifacts | |
- uses: actions/cache/save@v3 | |
# Don't create cache entries for the merge queue. | |
if: ${{ steps.cache.outputs.cache-hit != 'true' && github.event_name != 'merge_group' }} | |
with: | |
path: ${{ env.CACHED_PATH }} | |
key: ${{ steps.cache.outputs.cache-primary-key }} | |
- name: Dereference symlink | |
run: echo "UPLOAD_PATH=$(readlink -f result)" >> $GITHUB_ENV | |
- name: Upload artifact | |
uses: actions/upload-artifact@v3 | |
with: | |
name: noir_wasm | |
path: ${{ env.UPLOAD_PATH }} | |
retention-days: 3 | |
test: | |
needs: [build-wasm, build-nargo] | |
name: Test noir_wasm | |
runs-on: ubuntu-latest | |
steps: | |
- name: Checkout noir-lang/noir | |
uses: actions/checkout@v3 | |
- name: Download wasm package artifact | |
uses: actions/download-artifact@v3 | |
with: | |
name: noir_wasm | |
path: ./crates/wasm/result | |
- name: Download nargo binary | |
uses: actions/download-artifact@v3 | |
with: | |
name: nargo | |
path: ./nargo | |
- name: Compile test program with Nargo CLI | |
working-directory: ./crates/wasm/noir-script | |
run: | | |
nargo_binary=${{ github.workspace }}/nargo/nargo | |
chmod +x $nargo_binary | |
$nargo_binary compile | |
- name: Install dependencies | |
working-directory: ./crates/wasm | |
run: yarn install | |
- name: Install playwright deps | |
working-directory: ./crates/wasm | |
run: | | |
npx playwright install | |
npx playwright install-deps | |
- name: Run tests | |
working-directory: ./crates/wasm | |
run: | | |
yarn test:browser | |
yarn test:node |