chore: update recursion example for noir v0.25.0 #18
Conversation
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
Hey @CodeDragonVN im tried to make this work and was blocked since backend_barretenberg 0.24.0 points to bb.js 0.23.0 which causes serialization issues. Did you find any such problems? |
|
Ok so I stopped being lazy and checked this out, indeed I get the same serialization error: I'm glad to merge this branch though instead of my own branch because this frontend looks sweet! Let's just wait for 0.24.1 |
|
Hey @signorecello, I'm running into the serialization error you pointed out, and it's perplexing because it was previously resolved on my end. Testing now with the I'm finding it perplexing how It's working on my repo here: https://github.com/CodeDragonVN/noir-recursion-v0.24.0, but now it's giving me that serialization issue on this repo. The version of bb.js is also 0.23.0 on my repo. |
|
I've reopened the issue about the serialization error since it has resurfaced. I'm encountering it again, similar to before. My repo https://github.com/CodeDragonVN/noir-recursion-v0.24.0 shows no issues, but the serialization error persists in this noir-examples repo. The issue is Issue #4459 |
|
Thanks @CodeDragonVN this is a known problem, caused by feedback loop from aztec-packages repo that wasn't included in 0.24.0 by mistake. This is resolved in a next version 0.24.1 so it's just a matter of waiting for it. One way to check it will work correctly is just to use nightlies. Let's hold on this PR until then, I'll let you know once 0.24.1 is out and you can update this PR to reflect that, then we merge 👍 |
|
I get a bit distracted with so many PRs though so please tag me here, or on discord, if I fail to see changes! |
|
@signorecello Appreciated. I'll keep a close watch for the 0.24.1 release and update also. For now, I'll close the issue. |
|
hey @signorecello, I've got good news! After updating the packages to v0.25.0 the deserialization issue is gone.
|
|
Yep this one looks good, let's merge :) |
|
@SocketSecurity ignore npm/[email protected] |
Savio-Sou
changed the title
|
When running Is that expected? |
Description
Problem*
This Pull Request updates the recursion example to be compatible with Noir v0.24.0, addressing breaking changes introduced in the update. It resolves the issue described in: Update recursion to Noir v0.24.0 #16.
Summary*
The PR makes several changes to provide compatibility with Noir v0.24.0:
generateIntermediateProoftogenerateProof,verifyIntermediateProoftoverifyProof, etc.).yarn dev localhostto enhance user experience.#[recursive]attribute and updatedNargo.tomlfiles in line with Noir v0.24.0 requirements.Additional Context
PR Checklist*
cargo fmton default settings.